Skip to content

[NFCI] Change SpecialCaseList::inSectionBlame to return pair<uint, uint> (FileIdx, LineNo). #141540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025
+85 −49
Merged

[NFCI] Change SpecialCaseList::inSectionBlame to return pair<uint, uint> (FileIdx, LineNo). #141540

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7540c3
[𝘀𝗽𝗿] changes to main this commit is based on
qinkunbao May 27, 2025
98dd039
[𝘀𝗽𝗿] initial version
qinkunbao May 27, 2025
d5508cc
Format SpecialCaseList.h
qinkunbao May 27, 2025
b094fc2
Remove irelevant format changes
qinkunbao May 27, 2025
561e98b
review
qinkunbao May 28, 2025
a898b89
NotFound
qinkunbao May 28, 2025
cba26f2
static constexpr
qinkunbao May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/Support/SpecialCaseList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class FileSystem;
/// ---
class SpecialCaseList {
public:
constexpr static std::pair<unsigned, unsigned> NotFound = {0, 0};
static constexpr std::pair<unsigned, unsigned> NotFound = {0, 0};
Copy link
Member Author

@qinkunbao qinkunbao May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought static constexpr and constexpr static mean exactly the same thing

Copy link
Collaborator

@vitalybuka vitalybuka May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for consistency

/// Parses the special case list entries from files. On failure, returns
/// 0 and writes an error message to string.
LLVM_ABI static std::unique_ptr<SpecialCaseList>
Expand Down
Loading