[NewGVN] Check intrinsic ID before accessing operands

[mariusz-sikora-at-amd]

This patch is fixing assertions in downstream tests

[llvmbot]

@llvm/pr-subscribers-backend-amdgpu

@llvm/pr-subscribers-llvm-transforms

Author: Mariusz Sikora (mariusz-sikora-at-amd)

Changes

This patch is fixing assertions in downstream tests

---

Full diff: https://github.com/llvm/llvm-project/pull/141571.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Scalar/NewGVN.cpp (+6-5)

diff --git a/llvm/lib/Transforms/Scalar/NewGVN.cpp b/llvm/lib/Transforms/Scalar/NewGVN.cpp
index 85bd8ef1f09a8..584cb0e89ef66 100644
--- a/llvm/lib/Transforms/Scalar/NewGVN.cpp
+++ b/llvm/lib/Transforms/Scalar/NewGVN.cpp
@@ -1530,11 +1530,12 @@ NewGVN::performSymbolicLoadCoercion(Type *LoadType, Value *LoadPtr,
   }
 
   if (auto *II = dyn_cast<IntrinsicInst>(DepInst)) {
-    auto *LifetimePtr = II->getOperand(1);
-    if (II->getIntrinsicID() == Intrinsic::lifetime_start &&
-        (LoadPtr == lookupOperandLeader(LifetimePtr) ||
-         AA->isMustAlias(LoadPtr, LifetimePtr)))
-      return createConstantExpression(UndefValue::get(LoadType));
+    if (II->getIntrinsicID() == Intrinsic::lifetime_start) {
+      auto *LifetimePtr = II->getOperand(1);
+      if (LoadPtr == lookupOperandLeader(LifetimePtr) ||
+          AA->isMustAlias(LoadPtr, LifetimePtr))
+        return createConstantExpression(UndefValue::get(LoadType));
+    }
   }
 
   // All of the below are only true if the loaded pointer is produced

[dstutt]

Yes, LGTM

[ManuelJBrito]

Thank you!

[fhahn]

This patch is fixing assertions in downstream tests

Would it be possible to add the test?

[mariusz-sikora-at-amd]

This patch is fixing assertions in downstream tests

Would it be possible to add the test?

Yes, I will try to prepare a small test in a moment.

[kmitropoulou]

LGTM