[mlir][linalg][nfc] Move vectorization tests #141656
Conversation
Moves: * mlir/test/Dialect/Linalg/vectorization-with-patterns.mlir * mlir/test/Dialect/Linalg/vectorization.mlir * mlir/test/Dialect/Linalg/vectorization-unsupported.mlir to: * mlir/test/Dialect/Linalg/vectorization/ This patch implements part of llvm#141025 - please see the ticket for full context.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-linalg Author: Andrzej Warzyński (banach-space) ChangesMoves:
to:
This patch implements part of #141025 - please see the ticket for full Full diff: https://github.com/llvm/llvm-project/pull/141656.diff 3 Files Affected:
diff --git a/mlir/test/Dialect/Linalg/vectorization-with-patterns.mlir b/mlir/test/Dialect/Linalg/vectorization/linalg-ops-with-patterns.mlir
similarity index 100%
rename from mlir/test/Dialect/Linalg/vectorization-with-patterns.mlir
rename to mlir/test/Dialect/Linalg/vectorization/linalg-ops-with-patterns.mlir
diff --git a/mlir/test/Dialect/Linalg/vectorization.mlir b/mlir/test/Dialect/Linalg/vectorization/linalg-ops.mlir
similarity index 100%
rename from mlir/test/Dialect/Linalg/vectorization.mlir
rename to mlir/test/Dialect/Linalg/vectorization/linalg-ops.mlir
diff --git a/mlir/test/Dialect/Linalg/vectorization-unsupported.mlir b/mlir/test/Dialect/Linalg/vectorization/unsupported.mlir
similarity index 100%
rename from mlir/test/Dialect/Linalg/vectorization-unsupported.mlir
rename to mlir/test/Dialect/Linalg/vectorization/unsupported.mlir
|
hanhanW
left a comment
hanhanW
left a comment
There was a problem hiding this comment.
I'm okay with reviewing a large change if you break it into several commits, like what you're doing now. (I think the only difference is that it is PR-based, and I can do commit-based within a PR.)
Would it be better to submit a single PR for the ticket?
Sure, let me extend this PR. TBH, I kept it small to make sure some progress is made - I am trying to squeeze this in between other things 😅 |
* In vectorize-convolution.mlir, switch from `-test-linalg-transform-patterns=test-linalg-to-vector-patterns` to `transform.structured.vectorize_children_and_apply_patterns` (for consistency with other tests for vectorization). * Move + rename the remaining vectorization tests. * Add comments.
|
You may want to add |
3 participants
Moves all the remaining Linalg vectorization tests from:
mlir/tests/Dialect/Linalg/*to:
mlir/tests/Dialect/Linalg/vectorization/*To maintain consistency within tests,
vectorize-convolution.mlirwas updated to use:
transform.structured.vectorize_children_and_apply_patternsinstead of:
-test-linalg-transform-patterns=test-linalg-to-vector-patternsThis change required minor updates to some
CHECKlines, reflectingonly reordering of ops due to an additional pattern being applied.
Closes #141025