Skip to content

[AArch64] Remove VK_WEAKREF from arm64ec lowering. #141717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

[AArch64] Remove VK_WEAKREF from arm64ec lowering. #141717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions llvm/lib/Target/AArch64/AArch64MCInstLower.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,10 @@ MCSymbol *AArch64MCInstLower::GetGlobalValueSymbol(const GlobalValue *GV,
Printer.OutStreamer->emitSymbolAttribute(Printer.getSymbol(GV),
MCSA_WeakAntiDep);
Printer.OutStreamer->emitAssignment(
Printer.getSymbol(GV),
MCSymbolRefExpr::create(MangledSym, MCSymbolRefExpr::VK_WEAKREF,
Ctx));
Printer.getSymbol(GV), MCSymbolRefExpr::create(MangledSym, Ctx));
Printer.OutStreamer->emitSymbolAttribute(MangledSym, MCSA_WeakAntiDep);
Printer.OutStreamer->emitAssignment(
MangledSym,
MCSymbolRefExpr::create(Printer.getSymbol(GV),
MCSymbolRefExpr::VK_WEAKREF, Ctx));
MangledSym, MCSymbolRefExpr::create(Printer.getSymbol(GV), Ctx));
}

if (TargetFlags & AArch64II::MO_ARM64EC_CALLMANGLE)
Expand Down
1 change: 0 additions & 1 deletion llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ static cl::opt<AsmWriterVariantTy> AsmWriterVariant(

const MCAsmInfo::AtSpecifier COFFAtSpecifiers[] = {
{MCSymbolRefExpr::VK_COFF_IMGREL32, "IMGREL"},
{MCSymbolRefExpr::VK_WEAKREF, "WEAKREF"},
{AArch64MCExpr::M_PAGEOFF, "PAGEOFF"},
};

Expand Down
16 changes: 8 additions & 8 deletions llvm/test/CodeGen/AArch64/arm64ec-varargs.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ define void @varargs_caller() nounwind {
; CHECK-NEXT: stp x9, x8, [sp]
; CHECK-NEXT: str xzr, [sp, #16]
; CHECK-NEXT: .weak_anti_dep varargs_callee
; CHECK-NEXT: .set varargs_callee, "#varargs_callee"@WEAKREF
; CHECK-NEXT: .set varargs_callee, "#varargs_callee"
; CHECK-NEXT: .weak_anti_dep "#varargs_callee"
; CHECK-NEXT: .set "#varargs_callee", varargs_callee@WEAKREF
; CHECK-NEXT: .set "#varargs_callee", varargs_callee
; CHECK-NEXT: bl "#varargs_callee"
; CHECK-NEXT: ldr x30, [sp, #32] // 8-byte Folded Reload
; CHECK-NEXT: add sp, sp, #48
Expand Down Expand Up @@ -86,9 +86,9 @@ define void @varargs_many_argscalleer() nounwind {
; CHECK-NEXT: stp x9, x8, [sp]
; CHECK-NEXT: stp q0, q0, [sp, #16]
; CHECK-NEXT: .weak_anti_dep varargs_many_argscallee
; CHECK-NEXT: .set varargs_many_argscallee, "#varargs_many_argscallee"@WEAKREF
; CHECK-NEXT: .set varargs_many_argscallee, "#varargs_many_argscallee"
; CHECK-NEXT: .weak_anti_dep "#varargs_many_argscallee"
; CHECK-NEXT: .set "#varargs_many_argscallee", varargs_many_argscallee@WEAKREF
; CHECK-NEXT: .set "#varargs_many_argscallee", varargs_many_argscallee
; CHECK-NEXT: bl "#varargs_many_argscallee"
; CHECK-NEXT: ldr x30, [sp, #48] // 8-byte Folded Reload
; CHECK-NEXT: add sp, sp, #64
Expand Down Expand Up @@ -116,9 +116,9 @@ define void @varargs_caller_tail() nounwind {
; CHECK-NEXT: stp x9, x8, [sp]
; CHECK-NEXT: str xzr, [sp, #16]
; CHECK-NEXT: .weak_anti_dep varargs_callee
; CHECK-NEXT: .set varargs_callee, "#varargs_callee"@WEAKREF
; CHECK-NEXT: .set varargs_callee, "#varargs_callee"
; CHECK-NEXT: .weak_anti_dep "#varargs_callee"
; CHECK-NEXT: .set "#varargs_callee", varargs_callee@WEAKREF
; CHECK-NEXT: .set "#varargs_callee", varargs_callee
; CHECK-NEXT: bl "#varargs_callee"
; CHECK-NEXT: ldr x30, [sp, #32] // 8-byte Folded Reload
; CHECK-NEXT: add x4, sp, #48
Expand All @@ -129,9 +129,9 @@ define void @varargs_caller_tail() nounwind {
; CHECK-NEXT: mov x5, xzr
; CHECK-NEXT: add sp, sp, #48
; CHECK-NEXT: .weak_anti_dep varargs_callee
; CHECK-NEXT: .set varargs_callee, "#varargs_callee"@WEAKREF
; CHECK-NEXT: .set varargs_callee, "#varargs_callee"
; CHECK-NEXT: .weak_anti_dep "#varargs_callee"
; CHECK-NEXT: .set "#varargs_callee", varargs_callee@WEAKREF
; CHECK-NEXT: .set "#varargs_callee", varargs_callee
; CHECK-NEXT: b "#varargs_callee"
call void (double, ...) @varargs_callee(double 1.0, i32 2, double 3.0, i32 4, double 5.0, <2 x double> <double 0.0, double 0.0>)
tail call void (double, ...) @varargs_callee(double 1.0, i32 4, i32 3, i32 2)
Expand Down
Loading