Skip to content

[mlir] Recover the behavior of SliceAnaylsis for llvm-project@6a8dde04a07 #142076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

[mlir] Recover the behavior of SliceAnaylsis for llvm-project@6a8dde04a07 #142076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mlir/lib/Analysis/SliceAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,10 @@ static LogicalResult getBackwardSliceImpl(Operation *op,
return getBackwardSliceImpl(parentOp, backwardSlice, options);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this else return a failure? (to reflect the original assert?)

}
} else {
return failure();
}
return failure();
return success();
};

bool succeeded = true;
Expand Down
Loading