Skip to content

[MLIR] Reduce complexity of searching circular function calls in bufferization #142099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mscuttari merged 3 commits into from
Jun 6, 2025
Merged

[MLIR] Reduce complexity of searching circular function calls in bufferization #142099

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2095a7c
Reduce complexity of searching circular function calls
mscuttari May 30, 2025
336e546
Merge branch 'main' into quatradic-func-ordering
mscuttari Jun 5, 2025
494d06f
Merge branch 'main' into quatradic-func-ordering
mscuttari Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions mlir/lib/Dialect/Bufferization/Transforms/OneShotModuleBufferize.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,15 +341,25 @@ static LogicalResult getFuncOpsOrderedByCalls(

// Iteratively remove function operations that do not call any of the
// functions remaining in the callCounter map and add them to ordered list.
while (!numberCallOpsContainedInFuncOp.empty()) {
auto it = llvm::find_if(numberCallOpsContainedInFuncOp,
[](auto entry) { return entry.getSecond() == 0; });
if (it == numberCallOpsContainedInFuncOp.end())
break;
orderedFuncOps.push_back(it->getFirst());
for (auto callee : calledBy[it->getFirst()])
numberCallOpsContainedInFuncOp[callee]--;
numberCallOpsContainedInFuncOp.erase(it);
SmallVector<func::FuncOp> worklist;

for (const auto &entry : numberCallOpsContainedInFuncOp) {
if (entry.second == 0)
worklist.push_back(entry.first);
}

while (!worklist.empty()) {
func::FuncOp func = worklist.pop_back_val();
orderedFuncOps.push_back(func);

for (func::FuncOp caller : calledBy[func]) {
auto &count = numberCallOpsContainedInFuncOp[caller];

if (--count == 0)
worklist.push_back(caller);
}

numberCallOpsContainedInFuncOp.erase(func);
}

// Put all other functions in the list of remaining functions. These are
Expand Down