Skip to content

[LLDB][Platform Linux] Flip uid and pid in get signal description #142200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

[LLDB][Platform Linux] Flip uid and pid in get signal description #142200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05f09fa
Flip and add test
Jlalond May 30, 2025
ae1808d
Fix shell test
Jlalond May 30, 2025
06771cd
Switch test to require
Jlalond May 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ static std::string GetDescriptionFromSiginfo(lldb::ValueObjectSP siginfo_sp) {
}

return linux_signals.GetSignalDescription(signo, code, addr, lower, upper,
uid, pid);
pid, uid);
}

lldb::StopInfoSP PlatformLinux::GetStopInfoFromSiginfo(Thread &thread) {
Expand Down
10 changes: 10 additions & 0 deletions lldb/test/Shell/Register/Core/Inputs/tkill.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#include <signal.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The location of this test is under the "Register" directory, which looks like it is for testing things like register read. Since this is not about examining registers can we find a more suitable location?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it's weird. Strangely enough all the existing SIGINFO shell tests also live in this directory. I think it would lead to more confusion to break that, but it's a great refactoring opportunity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strangely enough all the existing SIGINFO shell tests also live in this directory

FWIW, I do see a command-thread-siginfo.test that lives outside this directory.

#include <sys/syscall.h>

int main() {
// Get the current thread ID
pid_t tid = syscall(SYS_gettid);
// Send a SIGSEGV signal to the current thread
syscall(SYS_tkill, tid, SIGSEGV);
return 0;
}
Binary file added lldb/test/Shell/Register/Core/Inputs/x86-64-linux-tkill.core
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions lldb/test/Shell/Register/Core/x86-64-linux-tkill.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# REQUIRES: system-linux
# RUN: %lldb -b -s %s -c %p/Inputs/x86-64-linux-tkill.core | FileCheck %s

thread list
# CHECK: hread #1: tid = 2667987, 0x00007f9a265076cd, name = 'tkill.out', stop reason = SIGSEGV: sent by tkill system call (sender pid=2667987, uid=649752)
Loading