Skip to content

Wrap ifndef NDEBUG around assertion-only code #142227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2025
Merged

Wrap ifndef NDEBUG around assertion-only code #142227

merged 1 commit into from
May 30, 2025

Conversation

@googlewalt
Copy link
Contributor

Otherwise we get unused variable warnings.

@googlewalt
Wrap ifndef NDEBUG around assertion-only code
c965709 
Otherwise we get unused variable warnings.
@googlewalt googlewalt requested a review from vporpo May 30, 2025 22:39
slackito
slackito approved these changes May 30, 2025
View reviewed changes
Copy link
Collaborator

@slackito slackito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you could #ifndef out the whole test instead. But this works too.

@googlewalt googlewalt merged commit 1d338a0 into llvm:main May 30, 2025
8 of 12 checks passed
@googlewalt googlewalt deleted the death branch October 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slackito slackito slackito approved these changes

@vporpo vporpo Awaiting requested review from vporpo

Assignees

No one assigned

Labels

llvm:SandboxIR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@googlewalt @slackito @llvmbot