[clang] Fix bad error recovery when classes are defined inside template

clang/include/clang/Parse/Parser.h

@@ -8909,6 +8909,8 @@ class Parser : public CodeCompletionHandler {
                             bool OuterMightBeMessageSend = false);
 
   ///@}
+
+  TemplateParameterLists *TemplateParamsFromAlias = nullptr;
 };
 
 } // end namespace clang

clang/lib/Parse/ParseDeclCXX.cpp

@@ -886,11 +886,17 @@ Decl *Parser::ParseAliasDeclarationAfterDeclarator(
         << FixItHint::CreateRemoval(SourceRange(D.EllipsisLoc));
 
   Decl *DeclFromDeclSpec = nullptr;
+
+  this->TemplateParamsFromAlias = TemplateInfo.TemplateParams;
+
   TypeResult TypeAlias =
       ParseTypeName(nullptr,
                     TemplateInfo.Kind != ParsedTemplateKind::NonTemplate ? DeclaratorContext::AliasTemplate
                                       : DeclaratorContext::AliasDecl,
                     AS, &DeclFromDeclSpec, &Attrs);
+
+  this->TemplateParamsFromAlias = nullptr;
+
   if (OwnedType)
     *OwnedType = DeclFromDeclSpec;
 
@@ -2173,6 +2179,17 @@ void Parser::ParseClassSpecifier(tok::TokenKind TagTokKind,
     assert(Tok.is(tok::l_brace) ||
            (getLangOpts().CPlusPlus && Tok.is(tok::colon)) ||
            isClassCompatibleKeyword());
+
+    if (TemplateParamsFromAlias) {
+      for (const TemplateParameterList *TPL : *TemplateParamsFromAlias) {
+        for (NamedDecl *D : *TPL) {
+          D->setInvalidDecl(true);
+          auto *TTPD = dyn_cast<TemplateTypeParmDecl>(D);
+          TTPD->setTypeForDecl(Actions.Context.IntTy.getTypePtr());
+        }
+      }
+    }
+
     if (SkipBody.ShouldSkip)
       SkipCXXMemberSpecification(StartLoc, AttrFixitLoc, TagType,
                                  TagOrTempResult.get());

clang/lib/Sema/SemaDecl.cpp

@@ -288,8 +288,8 @@ static ParsedType buildNamedType(Sema &S, const CXXScopeSpec *SS, QualType T,
   case Type::ObjCTypeParam:
   case Type::TemplateTypeParm:
     return ParsedType::make(T);
-  default:
-    llvm_unreachable("Unexpected Type Class");
+  //default:
+    //llvm_unreachable("Unexpected Type Class");
   }
 
   if (!SS || SS->isEmpty())

clang/test/SemaCXX/concept-crash-on-diagnostic.cpp

@@ -60,3 +60,16 @@ concept atomicish = requires() {
 };
 atomicish<int> f(); // expected-error {{expected 'auto' or 'decltype(auto)' after concept name}}
 } // namespace GH138820
+
+namespace GH91564 {
+template <class T> using A = struct B { // expected-error {{'GH91564::B' cannot be defined in a type alias template}}
+  template <class> void f() requires (T()); // expected-error {{atomic constraint must be of type 'bool' (found 'int')}} expected-note {{explicit instantiation refers here}}
+};
+template void B::f<void>(); // expected-error {{explicit instantiation of undefined function template 'f'}}
+
+template <class T> using C = struct D { // expected-error {{'GH91564::D' cannot be defined in a type alias template}}
+  using E = T;
+};
+template <class> void g() requires (D::E()); // expected-error {{atomic constraint must be of type 'bool' (found 'D::E' (aka 'int'))}} expected-note {{explicit instantiation refers here}}
+template void g<void>(); // expected-error {{explicit instantiation of undefined function template 'g'}}
+}