Skip to content

[AMDGPU] SIInsertHardClause: add configurable clause length limit #142343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
perlfu merged 2 commits into from
Jun 4, 2025
Merged

[AMDGPU] SIInsertHardClause: add configurable clause length limit #142343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75b5ef0
[AMDGPU] SIInsertHardClause add configurable clause length limit
perlfu Jun 2, 2025
3c62e28
- Address reviewer comments
perlfu Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ using namespace llvm;

#define DEBUG_TYPE "si-insert-hard-clauses"

static cl::opt<unsigned>
HardClauseLengthLimit("amdgpu-hard-clause-length-limit",
cl::desc("Maximum number of memory instructions to "
"place in the same hard clause"),
cl::init(255), cl::Hidden);

namespace {

enum HardClauseType {
Expand Down Expand Up @@ -185,11 +191,18 @@ class SIInsertHardClauses {
}

bool run(MachineFunction &MF) {

ST = &MF.getSubtarget<GCNSubtarget>();
if (!ST->hasHardClauses())
return false;

unsigned MaxClauseLength = MF.getFunction().getFnAttributeAsParsedInteger(
"amdgpu-hard-clause-length-limit", HardClauseLengthLimit);
if (HardClauseLengthLimit.getNumOccurrences())
MaxClauseLength = HardClauseLengthLimit;
MaxClauseLength = std::min(MaxClauseLength, ST->maxHardClauseLength());
if (!MaxClauseLength)
return false;

const SIInstrInfo *SII = ST->getInstrInfo();
const TargetRegisterInfo *TRI = ST->getRegisterInfo();

Expand All @@ -212,7 +225,7 @@ class SIInsertHardClauses {
}
}

if (CI.Length == ST->maxHardClauseLength() ||
if (CI.Length == MaxClauseLength ||
(CI.Length && Type != HARDCLAUSE_INTERNAL &&
Type != HARDCLAUSE_IGNORE &&
(Type != CI.Type ||
Expand Down
Loading
Loading