[gn build] Use shutil.which to find git in write_vcsrevision.py #142570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to llvm#54337 This is just a comment referencing distutils but even so, we can ditch the custom which and use the one Python 3.3 added. Which has the .bat bug fixed: https://docs.python.org/3.3/library/shutil.html#shutil.which I tested this on Windows: C:\Users\tcwg>touch foo.bat C:\Users\tcwg>python Python 3.11.9 (tags/v3.11.9:de54cf5, Apr 2 2024, 12:24:25) [MSC v.1938 64 bit (ARM64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import shutil >>> shutil.which("foo") '.\\foo.BAT' I just ran the script manually and got reasonable results, I haven't done a GN build.
DavidSpickett
changed the title
Collaborator
Author
|
ping! |
Collaborator
Author
|
ping! @nico |
Collaborator
Author
|
This is low risk and I'm sure a bot will complain eventually if there's a problem, so I'm going to land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #54337
This is just a comment referencing distutils but even so, we can ditch the custom which and use the one Python 3.3 added. Which has the .bat bug fixed:
https://docs.python.org/3.3/library/shutil.html#shutil.which
I tested this on Windows:
I just ran the script manually and got reasonable results, I haven't done a GN build.