Skip to content

Conversation

@DavidTruby
Copy link
Member

Hi all, I'd like to propose myself as a Maintainer for Flang on Windows.
I feel that this would be helpful to have an obvious point of contact for people submitting Windows issues for Flang, as well as reviews. While we don't generally see a huge number of Windows issues currently, I've worked with Windows on Flang in the past, for example in the following PRs: #120114, #116667, #90758, #72519; as well as helped other people fix Windows issues in their PRs: #130253, #108017, #74728.

I've added as reviewers a few people I have worked on Windows issues with in the past, and would like to ping a couple more who I can't add, if they'd like to give input (@h-vetinari @bradking).

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Jun 3, 2025
@tblah tblah requested review from dpalermo and luporl June 3, 2025 14:52
@DavidTruby DavidTruby requested a review from Meinersbur June 3, 2025 14:55
@Meinersbur
Copy link
Member

You have my ok, but should probably approved by code owners that so far had those responsibilities.

Copy link
Contributor

@tblah tblah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for review from outside Arm

Copy link
Contributor

@luporl luporl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, David has been involved in many Windows-related undertakings.

@h-vetinari
Copy link
Contributor

I've added as reviewers a few people I have worked on Windows issues with in the past, and would like to ping a couple more who I can't add, if they'd like to give input (@h-vetinari @bradking).

Thanks for the ping. I don't have a commit bit here (so my approval counts for little), but I'm very interested in keeping flang in good shape on windows, so I welcome any efforts to that effect. Thanks for stepping up @DavidTruby!

Copy link
Contributor

@jeanPerier jeanPerier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy with @DavidTruby taking this responsibility, thanks David!

@DavidTruby DavidTruby merged commit 46d9abb into llvm:main Jun 11, 2025
13 checks passed
@DavidTruby DavidTruby deleted the win branch June 11, 2025 13:50
@DavidTruby
Copy link
Member Author

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants