Skip to content

[BOLT] Zero initialize pre-aggregated counters #142698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2025
Merged

[BOLT] Zero initialize pre-aggregated counters #142698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b325976
[𝘀𝗽𝗿] changes to main this commit is based on
aaupov Jun 3, 2025
9aa218d
[𝘀𝗽𝗿] initial version
aaupov Jun 3, 2025
8f96bea
[𝘀𝗽𝗿] changes introduced through rebase
preames Jun 4, 2025
3cbd591
rebase
aaupov Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bolt/lib/Profile/DataAggregator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,7 +1220,7 @@ std::error_code DataAggregator::parseAggregatedLBREntry() {
// Storage for parsed fields.
StringRef EventName;
std::optional<Location> Addr[3];
int64_t Counters[2];
int64_t Counters[2] = {0};

while (Type == INVALID || Type == EVENT_NAME) {
while (checkAndConsumeFS()) {
Expand Down
4 changes: 4 additions & 0 deletions bolt/test/X86/entry-point-fallthru.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
# RUN: link_fdata %s %t %t.preagg PREAGG
# RUN: perf2bolt %t -p %t.preagg --pa -o %t.fdata | FileCheck %s
# CHECK: traces mismatching disassembled function contents: 0
# RUN: FileCheck %s --check-prefix=CHECK-FDATA --input-file %t.fdata
# CHECK-FDATA: 1 main 0 1 main 6 0 1
# CHECK-FDATA-NEXT: 1 main e 1 main 11 0 1
# CHECK-FDATA-NEXT: 1 main 11 1 main 0 0 1

.globl main
main:
Expand Down
Loading