Skip to content

[libc++] Fix basic_string::shrink_to_fit for constant evaluation #142712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

[libc++] Fix basic_string::shrink_to_fit for constant evaluation #142712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/include/string
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3434,8 +3434,8 @@ inline _LIBCPP_CONSTEXPR_SINCE_CXX20 void basic_string<_CharT, _Traits, _Allocat

if (__fits_in_sso(__target_capacity)) {
__annotation_guard __g(*this);
traits_type::copy(std::__to_address(__get_short_pointer()), std::__to_address(__ptr), __size + 1);
__set_short_size(__size);
traits_type::copy(std::__to_address(__get_short_pointer()), std::__to_address(__ptr), __size + 1);
__alloc_traits::deallocate(__alloc_, __ptr, __cap);
return;
}
Expand Down
2 changes: 1 addition & 1 deletion libcxx/test/std/strings/basic.string/string.capacity/shrink_to_fit.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include "test_macros.h"

template <class S>
TEST_CONSTEXPR_CXX20 void test(S s) {
TEST_CONSTEXPR_CXX20 void test(S& s) {
typename S::size_type old_cap = s.capacity();
S s0 = s;
s.shrink_to_fit();
Expand Down
Loading