Skip to content

[NFC] [DebugCounter] warn if --debug-counter is unused in NDEBUG #143057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2025
Merged

[NFC] [DebugCounter] warn if --debug-counter is unused in NDEBUG #143057

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcb2062
[𝘀𝗽𝗿] initial version
fmayer Jun 6, 2025
d67c37f
Update llvm/lib/Support/DebugCounter.cpp
fmayer Jun 6, 2025
510e42f
fmt
fmayer Jun 6, 2025
0dfd914
fmt2
fmayer Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llvm/lib/Support/DebugCounter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,11 @@ DebugCounter &DebugCounter::instance() {
void DebugCounter::push_back(const std::string &Val) {
if (Val.empty())
return;
#ifdef NDEBUG
// isCountingEnabled is hardcoded to false in NDEBUG.
errs() << "Requested --debug-counter in non-debug LLVM build. This is a "
"no-op.\n";
#endif

// The strings should come in as counter=chunk_list
auto CounterPair = StringRef(Val).split('=');
Expand Down
Loading