[llvm] Ensure newline at the end of files (NFC) #143061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without newlines at the end, git diff would display: No newline at end of file
llvmbot
added
backend:AArch64
backend:X86
backend:CSKY
llvm:analysis
Member
|
@llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-backend-x86 Author: Kazu Hirata (kazutakahirata) ChangesWithout newlines at the end, git diff would display: No newline at end of file Full diff: https://github.com/llvm/llvm-project/pull/143061.diff 13 Files Affected:
diff --git a/llvm/docs/_static/lines.gif b/llvm/docs/_static/lines.gif
index 88f491edc3026..c56b5e4ea1d65 100644
Binary files a/llvm/docs/_static/lines.gif and b/llvm/docs/_static/lines.gif differ
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
index 91c9eee554c06..460d5e8f9e49a 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
@@ -60,4 +60,4 @@ class DebugInfoPreservationPlugin : public ObjectLinkingLayer::Plugin {
} // namespace llvm
-#endif
\ No newline at end of file
+#endif
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
index 74329a048941a..179fedc3972ab 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
@@ -66,4 +66,4 @@ class LLVM_ABI PerfSupportPlugin : public ObjectLinkingLayer::Plugin {
} // namespace orc
} // namespace llvm
-#endif // LLVM_EXECUTIONENGINE_ORC_PERFSUPPORTPLUGIN_H
\ No newline at end of file
+#endif // LLVM_EXECUTIONENGINE_ORC_PERFSUPPORTPLUGIN_H
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h b/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
index f4788bcebc3cf..e3f9f78b9e1d8 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
@@ -230,4 +230,4 @@ class SPSSerializationTraits<SPSPerfJITRecordBatch, PerfJITRecordBatch> {
} // namespace llvm
-#endif
\ No newline at end of file
+#endif
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h b/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
index fa74c835d64b4..1aa187754ffa6 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
@@ -26,4 +26,4 @@ llvm_orc_registerJITLoaderPerfStart(const char *ArgData, size_t ArgSize);
extern "C" LLVM_ABI llvm::orc::shared::CWrapperFunctionResult
llvm_orc_registerJITLoaderPerfEnd(const char *ArgData, size_t ArgSize);
-#endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERPERF_H
\ No newline at end of file
+#endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERPERF_H
diff --git a/llvm/lib/Analysis/CFG.cpp b/llvm/lib/Analysis/CFG.cpp
index 0d32e101ee0b4..1676d6b6f592e 100644
--- a/llvm/lib/Analysis/CFG.cpp
+++ b/llvm/lib/Analysis/CFG.cpp
@@ -368,4 +368,4 @@ bool llvm::isPresplitCoroSuspendExitEdge(const BasicBlock &Src,
return Intr->getIntrinsicID() == Intrinsic::coro_suspend &&
SW->getDefaultDest() == &Dest;
return false;
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td b/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
index 0a0ce2fc76dde..a515cbdcc35fb 100644
--- a/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
+++ b/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
@@ -18,4 +18,4 @@ multiclass B_priv<string name> {
def export : P<"export">;
def alternatename : P<"alternatename">;
-def incl : Joined<["/", "-", "/?", "-?"], "include:">;
\ No newline at end of file
+def incl : Joined<["/", "-", "/?", "-?"], "include:">;
diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 04defbc977462..c5fb7f56e3ef7 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -246,4 +246,4 @@ void AArch64TargetStreamer::activateAtributesSubsection(StringRef VendorName) {
SubSection.IsActive = false;
}
}
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Target/CSKY/CSKYInstrAlias.td b/llvm/lib/Target/CSKY/CSKYInstrAlias.td
index e3c0538e752e6..bc63ce30d432c 100644
--- a/llvm/lib/Target/CSKY/CSKYInstrAlias.td
+++ b/llvm/lib/Target/CSKY/CSKYInstrAlias.td
@@ -35,4 +35,4 @@ def : InstAlias<"jsri $dst", (PseudoJSRI32 call_symbol:$dst)>;
def : InstAlias<"jsri $dst", (JSRI32 constpool_symbol:$dst)>;
def : InstAlias<"jmpi $dst", (PseudoJMPI32 br_symbol:$dst)>;
-def : InstAlias<"jmpi $dst", (JMPI32 constpool_symbol:$dst)>;
\ No newline at end of file
+def : InstAlias<"jmpi $dst", (JMPI32 constpool_symbol:$dst)>;
diff --git a/llvm/lib/Target/X86/X86RegisterInfo.cpp b/llvm/lib/Target/X86/X86RegisterInfo.cpp
index 71d36594afaeb..9adac067aace8 100644
--- a/llvm/lib/Target/X86/X86RegisterInfo.cpp
+++ b/llvm/lib/Target/X86/X86RegisterInfo.cpp
@@ -1280,4 +1280,4 @@ bool X86RegisterInfo::isNonRex2RegClass(const TargetRegisterClass *RC) const {
case X86::GR64_with_sub_16bit_in_GR16_NOREX2RegClassID:
return true;
}
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp b/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
index 5851262c8e7b6..b40e1f208bdad 100644
--- a/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
+++ b/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
@@ -252,4 +252,4 @@ bool X86SuppressAPXForRelocationPass::runOnMachineFunction(
Changed |= handleNDDOrNFInstructions(MF, ST);
return Changed;
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Transforms/IPO/StripSymbols.cpp b/llvm/lib/Transforms/IPO/StripSymbols.cpp
index 78bcd8b83bd28..ecd0ade131467 100644
--- a/llvm/lib/Transforms/IPO/StripSymbols.cpp
+++ b/llvm/lib/Transforms/IPO/StripSymbols.cpp
@@ -316,4 +316,4 @@ PreservedAnalyses StripDeadCGProfilePass::run(Module &M,
M.setModuleFlag(Module::Append, "CG Profile",
MDTuple::getDistinct(M.getContext(), ValidCGEdges));
return PreservedAnalyses::none();
-}
\ No newline at end of file
+}
diff --git a/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp b/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
index 35ea43232200f..d3cb134279a26 100644
--- a/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
+++ b/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
@@ -498,4 +498,4 @@ static Error trySizeSiff() {
}
static CommandRegistration RemarkSizeSiffRegister(&RemarkSizeDiffUtil,
- trySizeSiff);
\ No newline at end of file
+ trySizeSiff);
|
Member
|
@llvm/pr-subscribers-backend-aarch64 Author: Kazu Hirata (kazutakahirata) ChangesWithout newlines at the end, git diff would display: No newline at end of file Full diff: https://github.com/llvm/llvm-project/pull/143061.diff 13 Files Affected:
diff --git a/llvm/docs/_static/lines.gif b/llvm/docs/_static/lines.gif
index 88f491edc3026..c56b5e4ea1d65 100644
Binary files a/llvm/docs/_static/lines.gif and b/llvm/docs/_static/lines.gif differ
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
index 91c9eee554c06..460d5e8f9e49a 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
@@ -60,4 +60,4 @@ class DebugInfoPreservationPlugin : public ObjectLinkingLayer::Plugin {
} // namespace llvm
-#endif
\ No newline at end of file
+#endif
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
index 74329a048941a..179fedc3972ab 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
@@ -66,4 +66,4 @@ class LLVM_ABI PerfSupportPlugin : public ObjectLinkingLayer::Plugin {
} // namespace orc
} // namespace llvm
-#endif // LLVM_EXECUTIONENGINE_ORC_PERFSUPPORTPLUGIN_H
\ No newline at end of file
+#endif // LLVM_EXECUTIONENGINE_ORC_PERFSUPPORTPLUGIN_H
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h b/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
index f4788bcebc3cf..e3f9f78b9e1d8 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
@@ -230,4 +230,4 @@ class SPSSerializationTraits<SPSPerfJITRecordBatch, PerfJITRecordBatch> {
} // namespace llvm
-#endif
\ No newline at end of file
+#endif
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h b/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
index fa74c835d64b4..1aa187754ffa6 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
@@ -26,4 +26,4 @@ llvm_orc_registerJITLoaderPerfStart(const char *ArgData, size_t ArgSize);
extern "C" LLVM_ABI llvm::orc::shared::CWrapperFunctionResult
llvm_orc_registerJITLoaderPerfEnd(const char *ArgData, size_t ArgSize);
-#endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERPERF_H
\ No newline at end of file
+#endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERPERF_H
diff --git a/llvm/lib/Analysis/CFG.cpp b/llvm/lib/Analysis/CFG.cpp
index 0d32e101ee0b4..1676d6b6f592e 100644
--- a/llvm/lib/Analysis/CFG.cpp
+++ b/llvm/lib/Analysis/CFG.cpp
@@ -368,4 +368,4 @@ bool llvm::isPresplitCoroSuspendExitEdge(const BasicBlock &Src,
return Intr->getIntrinsicID() == Intrinsic::coro_suspend &&
SW->getDefaultDest() == &Dest;
return false;
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td b/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
index 0a0ce2fc76dde..a515cbdcc35fb 100644
--- a/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
+++ b/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
@@ -18,4 +18,4 @@ multiclass B_priv<string name> {
def export : P<"export">;
def alternatename : P<"alternatename">;
-def incl : Joined<["/", "-", "/?", "-?"], "include:">;
\ No newline at end of file
+def incl : Joined<["/", "-", "/?", "-?"], "include:">;
diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 04defbc977462..c5fb7f56e3ef7 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -246,4 +246,4 @@ void AArch64TargetStreamer::activateAtributesSubsection(StringRef VendorName) {
SubSection.IsActive = false;
}
}
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Target/CSKY/CSKYInstrAlias.td b/llvm/lib/Target/CSKY/CSKYInstrAlias.td
index e3c0538e752e6..bc63ce30d432c 100644
--- a/llvm/lib/Target/CSKY/CSKYInstrAlias.td
+++ b/llvm/lib/Target/CSKY/CSKYInstrAlias.td
@@ -35,4 +35,4 @@ def : InstAlias<"jsri $dst", (PseudoJSRI32 call_symbol:$dst)>;
def : InstAlias<"jsri $dst", (JSRI32 constpool_symbol:$dst)>;
def : InstAlias<"jmpi $dst", (PseudoJMPI32 br_symbol:$dst)>;
-def : InstAlias<"jmpi $dst", (JMPI32 constpool_symbol:$dst)>;
\ No newline at end of file
+def : InstAlias<"jmpi $dst", (JMPI32 constpool_symbol:$dst)>;
diff --git a/llvm/lib/Target/X86/X86RegisterInfo.cpp b/llvm/lib/Target/X86/X86RegisterInfo.cpp
index 71d36594afaeb..9adac067aace8 100644
--- a/llvm/lib/Target/X86/X86RegisterInfo.cpp
+++ b/llvm/lib/Target/X86/X86RegisterInfo.cpp
@@ -1280,4 +1280,4 @@ bool X86RegisterInfo::isNonRex2RegClass(const TargetRegisterClass *RC) const {
case X86::GR64_with_sub_16bit_in_GR16_NOREX2RegClassID:
return true;
}
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp b/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
index 5851262c8e7b6..b40e1f208bdad 100644
--- a/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
+++ b/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
@@ -252,4 +252,4 @@ bool X86SuppressAPXForRelocationPass::runOnMachineFunction(
Changed |= handleNDDOrNFInstructions(MF, ST);
return Changed;
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Transforms/IPO/StripSymbols.cpp b/llvm/lib/Transforms/IPO/StripSymbols.cpp
index 78bcd8b83bd28..ecd0ade131467 100644
--- a/llvm/lib/Transforms/IPO/StripSymbols.cpp
+++ b/llvm/lib/Transforms/IPO/StripSymbols.cpp
@@ -316,4 +316,4 @@ PreservedAnalyses StripDeadCGProfilePass::run(Module &M,
M.setModuleFlag(Module::Append, "CG Profile",
MDTuple::getDistinct(M.getContext(), ValidCGEdges));
return PreservedAnalyses::none();
-}
\ No newline at end of file
+}
diff --git a/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp b/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
index 35ea43232200f..d3cb134279a26 100644
--- a/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
+++ b/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
@@ -498,4 +498,4 @@ static Error trySizeSiff() {
}
static CommandRegistration RemarkSizeSiffRegister(&RemarkSizeDiffUtil,
- trySizeSiff);
\ No newline at end of file
+ trySizeSiff);
|
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Kazu Hirata (kazutakahirata) ChangesWithout newlines at the end, git diff would display: No newline at end of file Full diff: https://github.com/llvm/llvm-project/pull/143061.diff 13 Files Affected:
diff --git a/llvm/docs/_static/lines.gif b/llvm/docs/_static/lines.gif
index 88f491edc3026..c56b5e4ea1d65 100644
Binary files a/llvm/docs/_static/lines.gif and b/llvm/docs/_static/lines.gif differ
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
index 91c9eee554c06..460d5e8f9e49a 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/DebugInfoSupport.h
@@ -60,4 +60,4 @@ class DebugInfoPreservationPlugin : public ObjectLinkingLayer::Plugin {
} // namespace llvm
-#endif
\ No newline at end of file
+#endif
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
index 74329a048941a..179fedc3972ab 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Debugging/PerfSupportPlugin.h
@@ -66,4 +66,4 @@ class LLVM_ABI PerfSupportPlugin : public ObjectLinkingLayer::Plugin {
} // namespace orc
} // namespace llvm
-#endif // LLVM_EXECUTIONENGINE_ORC_PERFSUPPORTPLUGIN_H
\ No newline at end of file
+#endif // LLVM_EXECUTIONENGINE_ORC_PERFSUPPORTPLUGIN_H
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h b/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
index f4788bcebc3cf..e3f9f78b9e1d8 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/Shared/PerfSharedStructs.h
@@ -230,4 +230,4 @@ class SPSSerializationTraits<SPSPerfJITRecordBatch, PerfJITRecordBatch> {
} // namespace llvm
-#endif
\ No newline at end of file
+#endif
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h b/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
index fa74c835d64b4..1aa187754ffa6 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/JITLoaderPerf.h
@@ -26,4 +26,4 @@ llvm_orc_registerJITLoaderPerfStart(const char *ArgData, size_t ArgSize);
extern "C" LLVM_ABI llvm::orc::shared::CWrapperFunctionResult
llvm_orc_registerJITLoaderPerfEnd(const char *ArgData, size_t ArgSize);
-#endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERPERF_H
\ No newline at end of file
+#endif // LLVM_EXECUTIONENGINE_ORC_TARGETPROCESS_JITLOADERPERF_H
diff --git a/llvm/lib/Analysis/CFG.cpp b/llvm/lib/Analysis/CFG.cpp
index 0d32e101ee0b4..1676d6b6f592e 100644
--- a/llvm/lib/Analysis/CFG.cpp
+++ b/llvm/lib/Analysis/CFG.cpp
@@ -368,4 +368,4 @@ bool llvm::isPresplitCoroSuspendExitEdge(const BasicBlock &Src,
return Intr->getIntrinsicID() == Intrinsic::coro_suspend &&
SW->getDefaultDest() == &Dest;
return false;
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td b/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
index 0a0ce2fc76dde..a515cbdcc35fb 100644
--- a/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
+++ b/llvm/lib/ExecutionEngine/JITLink/COFFOptions.td
@@ -18,4 +18,4 @@ multiclass B_priv<string name> {
def export : P<"export">;
def alternatename : P<"alternatename">;
-def incl : Joined<["/", "-", "/?", "-?"], "include:">;
\ No newline at end of file
+def incl : Joined<["/", "-", "/?", "-?"], "include:">;
diff --git a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
index 04defbc977462..c5fb7f56e3ef7 100644
--- a/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
+++ b/llvm/lib/Target/AArch64/MCTargetDesc/AArch64TargetStreamer.cpp
@@ -246,4 +246,4 @@ void AArch64TargetStreamer::activateAtributesSubsection(StringRef VendorName) {
SubSection.IsActive = false;
}
}
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Target/CSKY/CSKYInstrAlias.td b/llvm/lib/Target/CSKY/CSKYInstrAlias.td
index e3c0538e752e6..bc63ce30d432c 100644
--- a/llvm/lib/Target/CSKY/CSKYInstrAlias.td
+++ b/llvm/lib/Target/CSKY/CSKYInstrAlias.td
@@ -35,4 +35,4 @@ def : InstAlias<"jsri $dst", (PseudoJSRI32 call_symbol:$dst)>;
def : InstAlias<"jsri $dst", (JSRI32 constpool_symbol:$dst)>;
def : InstAlias<"jmpi $dst", (PseudoJMPI32 br_symbol:$dst)>;
-def : InstAlias<"jmpi $dst", (JMPI32 constpool_symbol:$dst)>;
\ No newline at end of file
+def : InstAlias<"jmpi $dst", (JMPI32 constpool_symbol:$dst)>;
diff --git a/llvm/lib/Target/X86/X86RegisterInfo.cpp b/llvm/lib/Target/X86/X86RegisterInfo.cpp
index 71d36594afaeb..9adac067aace8 100644
--- a/llvm/lib/Target/X86/X86RegisterInfo.cpp
+++ b/llvm/lib/Target/X86/X86RegisterInfo.cpp
@@ -1280,4 +1280,4 @@ bool X86RegisterInfo::isNonRex2RegClass(const TargetRegisterClass *RC) const {
case X86::GR64_with_sub_16bit_in_GR16_NOREX2RegClassID:
return true;
}
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp b/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
index 5851262c8e7b6..b40e1f208bdad 100644
--- a/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
+++ b/llvm/lib/Target/X86/X86SuppressAPXForReloc.cpp
@@ -252,4 +252,4 @@ bool X86SuppressAPXForRelocationPass::runOnMachineFunction(
Changed |= handleNDDOrNFInstructions(MF, ST);
return Changed;
-}
\ No newline at end of file
+}
diff --git a/llvm/lib/Transforms/IPO/StripSymbols.cpp b/llvm/lib/Transforms/IPO/StripSymbols.cpp
index 78bcd8b83bd28..ecd0ade131467 100644
--- a/llvm/lib/Transforms/IPO/StripSymbols.cpp
+++ b/llvm/lib/Transforms/IPO/StripSymbols.cpp
@@ -316,4 +316,4 @@ PreservedAnalyses StripDeadCGProfilePass::run(Module &M,
M.setModuleFlag(Module::Append, "CG Profile",
MDTuple::getDistinct(M.getContext(), ValidCGEdges));
return PreservedAnalyses::none();
-}
\ No newline at end of file
+}
diff --git a/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp b/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
index 35ea43232200f..d3cb134279a26 100644
--- a/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
+++ b/llvm/tools/llvm-remarkutil/RemarkSizeDiff.cpp
@@ -498,4 +498,4 @@ static Error trySizeSiff() {
}
static CommandRegistration RemarkSizeSiffRegister(&RemarkSizeDiffUtil,
- trySizeSiff);
\ No newline at end of file
+ trySizeSiff);
|
arsenm
reviewed
Jun 6, 2025
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Do we have an actual policy on whether or not files should have newlines at EOF? Last time I went through the programmer's manual/developer policy/coding standards I don't remember seeing anything.
Contributor
Author
I am not aware of one actually although the vast majority of source files have newlines at EOF. |
Contributor
Github marks it as an error if it's missing so it should be there |
arsenm
approved these changes
Jun 6, 2025
Contributor
Yeah. I've seen reviewer comments about it in the past too. It might be worth putting something somewhere just so that it's official.
As an error? I thought it just reported it similar to |
Contributor
It's a whitespace warning. It let's you proceed but there is no reason to ignore it |
Collaborator
|
@boomanaiden154 Is there any way we can add missing newlines to the code_formatter check as an error? I realise code_formatter is the check most likely to be ignored in a PR..... |
Contributor
Yeah, it should be possible to do. It's mostly just a matter of someone actually getting it done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without newlines at the end, git diff would display:
No newline at end of file