[llvm-remarkutil] bitstream2yaml: Keep output file #143220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the output file on successful exit.
fhahn
reviewed
Jun 9, 2025
Contributor
fhahn
left a comment
fhahn
left a comment
There was a problem hiding this comment.
Looks fine, but could you expand the PR description with the motivation for keeping the output file.
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
Keep the output file on successful exit, otherwise `llvm-remarkutil bitstream2yaml -o filename.yaml ...` does not produce any output, because the output file is deleted when the tool exits.
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
Keep the output file on successful exit, otherwise `llvm-remarkutil bitstream2yaml -o filename.yaml ...` does not produce any output, because the output file is deleted when the tool exits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the output file on successful exit, otherwise
llvm-remarkutil bitstream2yaml -o filename.yaml ...does not produce any output, because the output file is deleted when the tool exits.