[llvm] Call hash_combine_range with ranges (NFC) #143225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now invoke hash_combine_range with a range.
Member
|
@llvm/pr-subscribers-llvm-support @llvm/pr-subscribers-llvm-transforms Author: Kazu Hirata (kazutakahirata) ChangesWe can now invoke hash_combine_range with a range. Full diff: https://github.com/llvm/llvm-project/pull/143225.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h
index 252b55163cb09..7765a4ab2ba98 100644
--- a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h
+++ b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h
@@ -27,7 +27,7 @@ template <> struct DenseMapInfo<SmallVector<sandboxir::Value *>> {
return SmallVector<sandboxir::Value *>({(sandboxir::Value *)-2});
}
static unsigned getHashValue(const SmallVector<sandboxir::Value *> &Vec) {
- return hash_combine_range(Vec.begin(), Vec.end());
+ return hash_combine_range(Vec);
}
static bool isEqual(const SmallVector<sandboxir::Value *> &Vec1,
const SmallVector<sandboxir::Value *> &Vec2) {
diff --git a/llvm/lib/Support/Windows/Path.inc b/llvm/lib/Support/Windows/Path.inc
index 0afd0141b525a..fdf9d540a6488 100644
--- a/llvm/lib/Support/Windows/Path.inc
+++ b/llvm/lib/Support/Windows/Path.inc
@@ -748,7 +748,7 @@ static std::error_code getStatus(HANDLE FileHandle, file_status &Result) {
PathHash = (static_cast<uint64_t>(Info.nFileIndexHigh) << 32ULL) |
static_cast<uint64_t>(Info.nFileIndexLow);
} else {
- PathHash = hash_combine_range(ntPath.begin(), ntPath.end());
+ PathHash = hash_combine_range(ntPath);
}
Result = file_status(
|
Member
|
@llvm/pr-subscribers-vectorizers Author: Kazu Hirata (kazutakahirata) ChangesWe can now invoke hash_combine_range with a range. Full diff: https://github.com/llvm/llvm-project/pull/143225.diff 2 Files Affected:
diff --git a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h
index 252b55163cb09..7765a4ab2ba98 100644
--- a/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h
+++ b/llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/VecUtils.h
@@ -27,7 +27,7 @@ template <> struct DenseMapInfo<SmallVector<sandboxir::Value *>> {
return SmallVector<sandboxir::Value *>({(sandboxir::Value *)-2});
}
static unsigned getHashValue(const SmallVector<sandboxir::Value *> &Vec) {
- return hash_combine_range(Vec.begin(), Vec.end());
+ return hash_combine_range(Vec);
}
static bool isEqual(const SmallVector<sandboxir::Value *> &Vec1,
const SmallVector<sandboxir::Value *> &Vec2) {
diff --git a/llvm/lib/Support/Windows/Path.inc b/llvm/lib/Support/Windows/Path.inc
index 0afd0141b525a..fdf9d540a6488 100644
--- a/llvm/lib/Support/Windows/Path.inc
+++ b/llvm/lib/Support/Windows/Path.inc
@@ -748,7 +748,7 @@ static std::error_code getStatus(HANDLE FileHandle, file_status &Result) {
PathHash = (static_cast<uint64_t>(Info.nFileIndexHigh) << 32ULL) |
static_cast<uint64_t>(Info.nFileIndexLow);
} else {
- PathHash = hash_combine_range(ntPath.begin(), ntPath.end());
+ PathHash = hash_combine_range(ntPath);
}
Result = file_status(
|
shiltian
approved these changes
Jun 7, 2025
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
We can now invoke hash_combine_range with a range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now invoke hash_combine_range with a range.