[clang-tidy][NFC] fix formatting of namespace-comment-check
#143305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) ChangesFixed formatting and codestyle issues in Follow up to #124265. Full diff: https://github.com/llvm/llvm-project/pull/143305.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp b/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
index 12e52d6afad56..c04bf361c40ca 100644
--- a/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
@@ -28,12 +28,14 @@ NamespaceCommentCheck::NamespaceCommentCheck(StringRef Name,
llvm::Regex::IgnoreCase),
ShortNamespaceLines(Options.get("ShortNamespaceLines", 1U)),
SpacesBeforeComments(Options.get("SpacesBeforeComments", 1U)),
- AllowOmittingNamespaceComments(Options.get("AllowOmittingNamespaceComments", false)) {}
+ AllowOmittingNamespaceComments(
+ Options.get("AllowOmittingNamespaceComments", false)) {}
void NamespaceCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "ShortNamespaceLines", ShortNamespaceLines);
Options.store(Opts, "SpacesBeforeComments", SpacesBeforeComments);
- Options.store(Opts, "AllowOmittingNamespaceComments", AllowOmittingNamespaceComments);
+ Options.store(Opts, "AllowOmittingNamespaceComments",
+ AllowOmittingNamespaceComments);
}
void NamespaceCommentCheck::registerMatchers(MatchFinder *Finder) {
@@ -108,7 +110,7 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
// Currently for nested namespace (n1::n2::...) the AST matcher will match foo
// then bar instead of a single match. So if we got a nested namespace we have
// to skip the next ones.
- for (const auto &EndOfNameLocation : Ends) {
+ for (const SourceLocation &EndOfNameLocation : Ends) {
if (Sources.isBeforeInTranslationUnit(ND->getLocation(), EndOfNameLocation))
return;
}
@@ -142,7 +144,7 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
SourceRange OldCommentRange(AfterRBrace, AfterRBrace);
std::string Message = "%0 not terminated with a closing comment";
- bool hasComment = false;
+ bool HasComment = false;
// Try to find existing namespace closing comment on the same line.
if (Tok.is(tok::comment) && NextTokenIsOnSameLine) {
@@ -161,7 +163,7 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
return;
}
- hasComment = true;
+ HasComment = true;
// Otherwise we need to fix the comment.
NeedLineBreak = Comment.starts_with("/*");
@@ -185,13 +187,13 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
}
std::string NamespaceNameForDiag =
- ND->isAnonymousNamespace() ? "anonymous namespace"
- : ("namespace '" + *NamespaceNameAsWritten + "'");
+ ND->isAnonymousNamespace()
+ ? "anonymous namespace"
+ : ("namespace '" + *NamespaceNameAsWritten + "'");
// If no namespace comment is allowed
- if(!hasComment && AllowOmittingNamespaceComments) {
+ if (!HasComment && AllowOmittingNamespaceComments)
return;
- }
std::string Fix(SpacesBeforeComments, ' ');
Fix.append("// namespace");
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) ChangesFixed formatting and codestyle issues in Follow up to #124265. Full diff: https://github.com/llvm/llvm-project/pull/143305.diff 1 Files Affected:
diff --git a/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp b/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
index 12e52d6afad56..c04bf361c40ca 100644
--- a/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
+++ b/clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
@@ -28,12 +28,14 @@ NamespaceCommentCheck::NamespaceCommentCheck(StringRef Name,
llvm::Regex::IgnoreCase),
ShortNamespaceLines(Options.get("ShortNamespaceLines", 1U)),
SpacesBeforeComments(Options.get("SpacesBeforeComments", 1U)),
- AllowOmittingNamespaceComments(Options.get("AllowOmittingNamespaceComments", false)) {}
+ AllowOmittingNamespaceComments(
+ Options.get("AllowOmittingNamespaceComments", false)) {}
void NamespaceCommentCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "ShortNamespaceLines", ShortNamespaceLines);
Options.store(Opts, "SpacesBeforeComments", SpacesBeforeComments);
- Options.store(Opts, "AllowOmittingNamespaceComments", AllowOmittingNamespaceComments);
+ Options.store(Opts, "AllowOmittingNamespaceComments",
+ AllowOmittingNamespaceComments);
}
void NamespaceCommentCheck::registerMatchers(MatchFinder *Finder) {
@@ -108,7 +110,7 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
// Currently for nested namespace (n1::n2::...) the AST matcher will match foo
// then bar instead of a single match. So if we got a nested namespace we have
// to skip the next ones.
- for (const auto &EndOfNameLocation : Ends) {
+ for (const SourceLocation &EndOfNameLocation : Ends) {
if (Sources.isBeforeInTranslationUnit(ND->getLocation(), EndOfNameLocation))
return;
}
@@ -142,7 +144,7 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
SourceRange OldCommentRange(AfterRBrace, AfterRBrace);
std::string Message = "%0 not terminated with a closing comment";
- bool hasComment = false;
+ bool HasComment = false;
// Try to find existing namespace closing comment on the same line.
if (Tok.is(tok::comment) && NextTokenIsOnSameLine) {
@@ -161,7 +163,7 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
return;
}
- hasComment = true;
+ HasComment = true;
// Otherwise we need to fix the comment.
NeedLineBreak = Comment.starts_with("/*");
@@ -185,13 +187,13 @@ void NamespaceCommentCheck::check(const MatchFinder::MatchResult &Result) {
}
std::string NamespaceNameForDiag =
- ND->isAnonymousNamespace() ? "anonymous namespace"
- : ("namespace '" + *NamespaceNameAsWritten + "'");
+ ND->isAnonymousNamespace()
+ ? "anonymous namespace"
+ : ("namespace '" + *NamespaceNameAsWritten + "'");
// If no namespace comment is allowed
- if(!hasComment && AllowOmittingNamespaceComments) {
+ if (!HasComment && AllowOmittingNamespaceComments)
return;
- }
std::string Fix(SpacesBeforeComments, ' ');
Fix.append("// namespace");
|
carlosgalvezp
approved these changes
Jun 8, 2025
tomtor
pushed a commit
to tomtor/llvm-project
that referenced
this pull request
Jun 14, 2025
…43305) Fixed formatting and codestyle issues in `namespace-comment-check` Follow up to llvm#124265.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed formatting and codestyle issues in
namespace-comment-checkFollow up to #124265.