-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[X86] Use X86FixupInstTunings to select between (V)MOVSS/D and (V)BLENDPS/D #143312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4547715
[X86] Use X86FixupInstTunings to select between (V)MOVSS/D and (V)BLE…
houngkoungting 135e8bd
[X86] Tune X86FixupInstTuning to improve scheduling for MOVSS/D blend…
houngkoungting 934de03
[X86] Update llc tests after optimizing VBLENDPS to VMOVSS
houngkoungting 30577d5
[X86] Update llc tests after optimizing VBLENDPS to VMOVSS
houngkoungting 1604a5e
[X86] Update llc tests after optimizing VBLENDPS to VMOVSS
houngkoungting c40e46d
[X86] Update test case and code
houngkoungting File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -221,8 +221,41 @@ bool X86FixupInstTuningPass::processInstruction( | |
| auto ProcessUNPCKPS = [&](unsigned NewOpc) -> bool { | ||
| return ProcessUNPCKToIntDomain(NewOpc); | ||
| }; | ||
|
|
||
| auto ProcessBLENDToMOV = [&](unsigned MovOpc) -> bool { | ||
| if (!MI.getOperand(NumOperands - 1).isImm() || | ||
| MI.getOperand(NumOperands - 1).getImm() != 1) | ||
| return false; | ||
|
|
||
| bool Force = MF.getFunction().hasOptSize(); | ||
|
|
||
| if (!Force && !NewOpcPreferable(MovOpc)) | ||
| return false; | ||
| MI.setDesc(TII->get(MovOpc)); | ||
| MI.removeOperand(NumOperands - 1); | ||
| return true; | ||
| }; | ||
| switch (Opc) { | ||
| case X86::VBLENDPSrri: | ||
| case X86::VBLENDPSYrri: | ||
| case X86::VBLENDMPSZ128rrkz: | ||
| case X86::VBLENDMPSZ256rrkz: | ||
| case X86::VBLENDMPSZrrkz: { | ||
RKSimon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| int Imm = MI.getOperand(NumOperands - 1).getImm(); | ||
| if (Imm != 1) | ||
| return false; | ||
RKSimon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| return ProcessBLENDToMOV(X86::VMOVSSrr); | ||
| } | ||
| case X86::VBLENDPDrri: | ||
| case X86::VBLENDPDYrri: | ||
| case X86::VBLENDMPDZ128rrkz: | ||
| case X86::VBLENDMPDZ256rrkz: | ||
| case X86::VBLENDMPDZrrkz: { | ||
RKSimon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| int Imm = MI.getOperand(NumOperands - 1).getImm(); | ||
| if (Imm != 1) | ||
| return false; | ||
|
||
| return ProcessBLENDToMOV(X86::VMOVSDrr); | ||
| } | ||
| case X86::VPERMILPDri: | ||
| return ProcessVPERMILPDri(X86::VSHUFPDrri); | ||
| case X86::VPERMILPDYri: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.