[GlobalISel] Split Legalizer debug ouput into paragraphs. NFC #143427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps make the legalizer output easier to read, splitting each instructions legalization into a separate block.
Member
|
@llvm/pr-subscribers-llvm-globalisel Author: David Green (davemgreen) ChangesThis helps keep the legalizer output easier to read, splitting each instructions legalization into a separate block. Full diff: https://github.com/llvm/llvm-project/pull/143427.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index 83ba71e4c9d49..028bffd1bf5a7 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -118,7 +118,7 @@ LegalizerHelper::LegalizerHelper(MachineFunction &MF, const LegalizerInfo &LI,
LegalizerHelper::LegalizeResult
LegalizerHelper::legalizeInstrStep(MachineInstr &MI,
LostDebugLocObserver &LocObserver) {
- LLVM_DEBUG(dbgs() << "Legalizing: " << MI);
+ LLVM_DEBUG(dbgs() << "\nLegalizing: " << MI);
MIRBuilder.setInstrAndDebugLoc(MI);
|
arsenm
approved these changes
Jun 9, 2025
Collaborator
Author
|
I happened just to be testing it to make sure it hadn't bitrotted. I'm not sure why it was merged in though, it is best to ask before doing that. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/30807 Here is the relevant piece of the build log for the reference |
Contributor
OK, sorry, it's my fault. I'll pay more attention next time |
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
…43427) This helps keep the legalizer output easier to read, splitting each instructions legalization into a separate block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps keep the legalizer output easier to read, splitting each instructions legalization into a separate block.