Skip to content

Conversation

@rampitec
Copy link
Collaborator

@rampitec rampitec commented Jun 9, 2025

Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.

Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.
Copy link
Collaborator Author

rampitec commented Jun 9, 2025

@rampitec rampitec requested a review from arsenm June 9, 2025 19:49
@rampitec rampitec requested a review from jayfoad June 9, 2025 19:50
@rampitec rampitec marked this pull request as ready for review June 9, 2025 19:50
@llvmbot
Copy link
Member

llvmbot commented Jun 9, 2025

@llvm/pr-subscribers-backend-amdgpu

Author: Stanislav Mekhanoshin (rampitec)

Changes

Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.


Full diff: https://github.com/llvm/llvm-project/pull/143428.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SIInstrInfo.td (+2-2)
diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.td b/llvm/lib/Target/AMDGPU/SIInstrInfo.td
index 083345d4d1e12..9c1d82b50c1a5 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrInfo.td
+++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.td
@@ -2671,8 +2671,8 @@ class VOPProfile <list<ValueType> _ArgVT, bit _EnableClamp = 0> {
   // the asm operand name via this HasModifiers flag
   field string AsmDPP8 = getAsmDPP8<HasDst, NumSrcArgs, 0 /*HasModifiers*/, DstVT>.ret;
   field string AsmVOP3Base = getAsmVOP3Base<NumSrcArgs, HasDst, HasClamp,
-   HasOpSel, HasOMod, IsVOP3P, HasNeg, HasModifiers, HasModifiers,
-   HasModifiers, DstVT, HasFP8ByteSel>.ret;
+   HasOpSel, HasOMod, IsVOP3P, HasNeg, HasSrc0Mods, HasSrc1Mods,
+   HasSrc2Mods, DstVT, HasFP8ByteSel>.ret;
   field string Asm64 = AsmVOP3Base;
   field string AsmVOP3P = getAsmVOP3P<HasDst, NumSrcArgs, HasNeg, HasClamp, HasOpSel>.ret;
   field string AsmVOP3OpSel = getAsmVOP3OpSel<NumSrcArgs,

@rampitec rampitec merged commit ba7c646 into main Jun 9, 2025
11 checks passed
@rampitec rampitec deleted the users/rampitec/06-09-_amdgpu_fix_getasmvop3base_srcmods_arguments._nfci branch June 9, 2025 22:32
tomtor pushed a commit to tomtor/llvm-project that referenced this pull request Jun 14, 2025
Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants