[CI] Use Github Native Groups in monolithic-* scripts #143481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
boomanaiden154
requested review from
DavidSpickett,
Endilll,
cmtice,
lnihlen and
tstellar
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
DavidSpickett
approved these changes
Jun 10, 2025
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
LGTM
Looking forward to the other things we can do once there is only GitHub to think about.
Endilll
approved these changes
Jun 10, 2025
Contributor
Endilll
left a comment
Endilll
left a comment
There was a problem hiding this comment.
It would be nice to give them properly formatted names (e.g. Ninja Runtimes (Clang modules)), because when I wrote them, the context I expected them to be seen was local editor with lengthy log file opened. Now it's going to be in UI.
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Jun 22, 2025
This patch updates monolithic-linux.sh and monolithic-windows.sh to emit expandable groups in the Github logs. The syntax this replaces originally worked to produce the same functionality on Buildkite, but Github uses a different syntax. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#grouping-log-lines Pull Request: llvm#143481
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.ci-use-github-native-groups-in-monolithic-scripts
to
main
boomanaiden154
deleted the
users/boomanaiden154/ci-use-github-native-groups-in-monolithic-scripts
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jul 1, 2025
This patch updates monolithic-linux.sh and monolithic-windows.sh to emit expandable groups in the Github logs. The syntax this replaces originally worked to produce the same functionality on Buildkite, but Github uses a different syntax. https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#grouping-log-lines Reviewers: cmtice, DavidSpickett, tstellar, lnihlen, Endilll Reviewed By: Endilll, DavidSpickett Pull Request: llvm/llvm-project#143481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates monolithic-linux.sh and monolithic-windows.sh to emit
expandable groups in the Github logs. The syntax this replaces
originally worked to produce the same functionality on Buildkite, but
Github uses a different syntax.
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#grouping-log-lines