Skip to content

Disable prctl test when building for arm or riscv. #143627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

Disable prctl test when building for arm or riscv. #143627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c8f854
Disable prctl test when building for arm or riscv
amykhuang Jun 10, 2025
aedce4c
Add comment to the prctl test file.
amykhuang Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions libc/test/src/sys/prctl/linux/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
add_custom_target(libc_sys_prctl_unittests)

# Temporarily disable this test while setting up arm and riscv buildbots
# using qemu, since PR_GET_THP_DISABLE is not supported on qemu.
if (NOT (LIBC_TARGET_ARCHITECTURE_IS_ARM OR
LIBC_TARGET_ARCHITECTURE_IS_RISCV32 OR
LIBC_TARGET_ARCHITECTURE_IS_RISCV64))
add_libc_unittest(
prctl_test
SUITE
Expand All @@ -13,3 +18,4 @@ add_libc_unittest(
libc.test.UnitTest.ErrnoCheckingTest
libc.test.UnitTest.ErrnoSetterMatcher
)
endif()
1 change: 1 addition & 0 deletions libc/test/src/sys/prctl/linux/prctl_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ TEST_F(LlvmLibcSysPrctlTest, GetSetName) {
TEST_F(LlvmLibcSysPrctlTest, GetTHPDisable) {
// Manually check errno since the return value logic here is not
// covered in ErrnoSetterMatcher.
// Note that PR_GET_THP_DISABLE is not supported by QEMU.
int ret = LIBC_NAMESPACE::prctl(PR_GET_THP_DISABLE, 0, 0, 0, 0);
ASSERT_ERRNO_SUCCESS();
// PR_GET_THP_DISABLE return (as the function result) the current
Expand Down
Loading