[HIP] Remove dots in HIP runtime path

[scchan]

Remove the dots in the HIP path before passing to the rpath flag

[llvmbot]

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Siu Chi Chan (scchan)

Changes

Remove the dots in the HIP path before passing to the rpath flag

---

Full diff: https://github.com/llvm/llvm-project/pull/143792.diff

1 Files Affected:

• (modified) clang/lib/Driver/ToolChains/Linux.cpp (+5-2)

diff --git a/clang/lib/Driver/ToolChains/Linux.cpp b/clang/lib/Driver/ToolChains/Linux.cpp
index 151b2bfced818..9bfe3a9346efa 100644
--- a/clang/lib/Driver/ToolChains/Linux.cpp
+++ b/clang/lib/Driver/ToolChains/Linux.cpp
@@ -743,9 +743,12 @@ void Linux::AddHIPRuntimeLibArgs(const ArgList &Args,
       Args.MakeArgString(StringRef("-L") + RocmInstallation->getLibPath()));
 
   if (Args.hasFlag(options::OPT_frtlib_add_rpath,
-                   options::OPT_fno_rtlib_add_rpath, false))
+                   options::OPT_fno_rtlib_add_rpath, false)) {
+    SmallString<0> p = RocmInstallation->getLibPath();
+    llvm::sys::path::remove_dots(p);
     CmdArgs.append(
-        {"-rpath", Args.MakeArgString(RocmInstallation->getLibPath())});
+        {"-rpath", Args.MakeArgString(p)});
+  }
 
   CmdArgs.push_back("-lamdhip64");
 }

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[yxsamliu]

so far the preferred style is like remove_dots(p, /*remove_dot_dot=*/ true);