Skip to content

[lldb] Properly handle locate module callback when Target change arch #143793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

[lldb] Properly handle locate module callback when Target change arch #143793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/source/Target/Target.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,6 +1706,8 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec, bool set_platform,
if (PlatformSP arch_platform_sp =
GetDebugger().GetPlatformList().GetOrCreate(other, {},
&platform_arch)) {
arch_platform_sp->SetLocateModuleCallback(
platform_sp->GetLocateModuleCallback());
Comment on lines +1709 to +1710
Copy link
Collaborator

@clayborg clayborg Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This almost seems like the SetLocateModuleCallback should be on the target instead of on the platform. But this will work around the issue for sure.

SetPlatform(arch_platform_sp);
if (platform_arch.IsValid())
other = platform_arch;
Expand Down
Loading