Skip to content

[NFC] Pack MDNodeKeyImpl<DILocation> from 40 to 32 bytes #143891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

[NFC] Pack MDNodeKeyImpl<DILocation> from 40 to 32 bytes #143891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions llvm/lib/IR/LLVMContextImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,36 +310,33 @@ template <> struct MDNodeKeyImpl<MDTuple> : MDNodeOpsKey {

/// DenseMapInfo for DILocation.
template <> struct MDNodeKeyImpl<DILocation> {
unsigned Line;
uint16_t Column;
Metadata *Scope;
Metadata *InlinedAt;
bool ImplicitCode;
#ifdef EXPERIMENTAL_KEY_INSTRUCTIONS
uint64_t AtomGroup : 61;
uint64_t AtomRank : 3;
#endif
unsigned Line;
uint16_t Column;
bool ImplicitCode;

MDNodeKeyImpl(unsigned Line, uint16_t Column, Metadata *Scope,
Metadata *InlinedAt, bool ImplicitCode, uint64_t AtomGroup,
uint8_t AtomRank)
: Line(Line), Column(Column), Scope(Scope), InlinedAt(InlinedAt),
ImplicitCode(ImplicitCode)
: Scope(Scope), InlinedAt(InlinedAt),
#ifdef EXPERIMENTAL_KEY_INSTRUCTIONS
,
AtomGroup(AtomGroup), AtomRank(AtomRank)
AtomGroup(AtomGroup), AtomRank(AtomRank),
#endif
{
Line(Line), Column(Column), ImplicitCode(ImplicitCode) {
}

MDNodeKeyImpl(const DILocation *L)
: Line(L->getLine()), Column(L->getColumn()), Scope(L->getRawScope()),
InlinedAt(L->getRawInlinedAt()), ImplicitCode(L->isImplicitCode())
: Scope(L->getRawScope()), InlinedAt(L->getRawInlinedAt()),
#ifdef EXPERIMENTAL_KEY_INSTRUCTIONS
,
AtomGroup(L->getAtomGroup()), AtomRank(L->getAtomRank())
AtomGroup(L->getAtomGroup()), AtomRank(L->getAtomRank()),
#endif
{
Line(L->getLine()), Column(L->getColumn()),
ImplicitCode(L->isImplicitCode()) {
}

bool isKeyOf(const DILocation *RHS) const {
Expand Down
Loading