Skip to content

[lldb][DWARF] Don't try to compute address range information of forward declarations #144059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2025
Merged

[lldb][DWARF] Don't try to compute address range information of forward declarations #144059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cdb3a8b
[lldb][DWARF] Don't try to compute address range information of forwa…
Michael137 Jun 13, 2025
939fe5a
fixup! add comment
Michael137 Jun 13, 2025
9856f35
fixup! remove test
Michael137 Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,8 @@ void DWARFDebugInfoEntry::BuildFunctionAddressRangeTable(
DWARFUnit *cu, DWARFDebugAranges *debug_aranges) const {
Log *log = GetLog(DWARFLog::DebugInfo);
if (m_tag) {
if (m_tag == DW_TAG_subprogram) {
if (m_tag == DW_TAG_subprogram &&
!GetAttributeValueAsOptionalUnsigned(cu, DW_AT_declaration)) {
if (llvm::Expected<llvm::DWARFAddressRangesVector> ranges =
GetAttributeAddressRanges(cu, /*check_hi_lo_pc=*/true)) {
for (const auto &r : *ranges)
Expand Down
25 changes: 25 additions & 0 deletions lldb/test/Shell/SymbolFile/DWARF/forward-declaration-address-ranges.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Test that we don't try to determine address range
# information of forward declaration DIEs which have
# no DW_AT_low_pc/DW_AT_high_pc in DWARF.

# RUN: split-file %s %t
# RUN: %clang_host -c -g -gdwarf %t/main.cpp -o %t.o
# RUN: %lldb -x -b -s %t/commands.input %t.o -o exit 2>&1 \
# RUN: | FileCheck %s

#--- main.cpp

struct Foo {
void func() {}
} foo;

void baz() {
foo.func();
}

#--- commands.input

log enable -v dwarf info
target modules lookup -n func

# CHECK-NOT: DIE has no address range information
Loading