[Clang] use colon char instead of token name

[a-tarasyuk]

Fixes regression of https://github.com/llvm/llvm-project/pull/143460/files#r2144925614

[llvmbot]

@llvm/pr-subscribers-clang

Author: Oleksandr T. (a-tarasyuk)

Changes

Fixes regression of https://github.com/llvm/llvm-project/pull/143460/files#r2144925614

---

Full diff: https://github.com/llvm/llvm-project/pull/144068.diff

1 Files Affected:

• (modified) clang/lib/Parse/ParseStmt.cpp (+1-2)

diff --git a/clang/lib/Parse/ParseStmt.cpp b/clang/lib/Parse/ParseStmt.cpp
index c00759893b0c4..eb761c3b90523 100644
--- a/clang/lib/Parse/ParseStmt.cpp
+++ b/clang/lib/Parse/ParseStmt.cpp
@@ -836,8 +836,7 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext StmtCtx,
 
       Diag(ExpectedLoc, diag::err_expected_after)
           << "'case'" << tok::colon
-          << FixItHint::CreateInsertion(ExpectedLoc,
-                                        tok::getTokenName(tok::colon));
+          << FixItHint::CreateInsertion(ExpectedLoc, ":");
 
       ColonLoc = ExpectedLoc;
     }

[a-tarasyuk]

/cc @rkirsling

[Fznamznon]

Can we add a test?

[rkirsling]

Ohh, you beat me by a minute. 😆 I suppose #144069 could be closed then.

[AaronBallman]

This one also LGTM, I don't have a strong preference for this PR or the other one. :-)

[a-tarasyuk]

Ohh, you beat me by a minute. 😆 I suppose #144069 could be closed then.

@rkirsling You can copy the tests/changes from this PR into yours — I'll close this one.

[rkirsling]

I believe I'd need somebody to hit the merge button for me regardless, so I think we can just merge whichever one and close the other. 😅 The two approaches are mostly the same, I just figured that the surrounding code was consistent in using a literal ":", while there doesn't seem to be a precedent for using tok::getPunctuatorSpelling with a constant.

Either way, sorry to cause a run-around!

[a-tarasyuk]

@rkirsling, this test does not verify the fix https://github.com/llvm/llvm-project/pull/144069/files#diff-b87b117875d2e75dc1ef39535756591a688853bbeb7f83e5b4df6bafca111fa0R239-R241

switch-recovery.cpp doesn't use FileCheck

[rkirsling]

Oh oops! Thanks for the correction.

Edit: Fixed now.