Skip to content

[CIR] Upstream ComplexType ImaginaryLiteral #144223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

[CIR] Upstream ComplexType ImaginaryLiteral #144223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
167ea0d
[CIR] Upstream ComplexType ImaginaryLiteral
AmrDeveloper Jun 14, 2025
3af1d0f
Add test case for complex int
AmrDeveloper Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions clang/lib/CIR/CodeGen/CIRGenExprComplex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ class ComplexExprEmitter : public StmtVisitor<ComplexExprEmitter, mlir::Value> {
bool isInit);

mlir::Value VisitInitListExpr(InitListExpr *e);

mlir::Value VisitImaginaryLiteral(const ImaginaryLiteral *il);
};

} // namespace
Expand Down Expand Up @@ -66,6 +68,34 @@ mlir::Value ComplexExprEmitter::VisitInitListExpr(InitListExpr *e) {
return builder.create<cir::ConstantOp>(loc, complexAttr);
}

mlir::Value
ComplexExprEmitter::VisitImaginaryLiteral(const ImaginaryLiteral *il) {
auto ty = mlir::cast<cir::ComplexType>(cgf.convertType(il->getType()));
mlir::Type elementTy = ty.getElementType();
mlir::Location loc = cgf.getLoc(il->getExprLoc());

mlir::TypedAttr realValueAttr;
mlir::TypedAttr imagValueAttr;

if (mlir::isa<cir::IntType>(elementTy)) {
llvm::APInt imagValue = cast<IntegerLiteral>(il->getSubExpr())->getValue();
realValueAttr = cir::IntAttr::get(elementTy, 0);
imagValueAttr = cir::IntAttr::get(elementTy, imagValue);
} else {
assert(mlir::isa<cir::CIRFPTypeInterface>(elementTy) &&
"Expected complex element type to be floating-point");

llvm::APFloat imagValue =
cast<FloatingLiteral>(il->getSubExpr())->getValue();
realValueAttr = cir::FPAttr::get(
elementTy, llvm::APFloat::getZero(imagValue.getSemantics()));
imagValueAttr = cir::FPAttr::get(elementTy, imagValue);
}

auto complexAttr = cir::ConstComplexAttr::get(realValueAttr, imagValueAttr);
return builder.create<cir::ConstantOp>(loc, complexAttr);
}

mlir::Value CIRGenFunction::emitComplexExpr(const Expr *e) {
assert(e && getComplexType(e->getType()) &&
"Invalid complex expression to emit");
Expand Down
14 changes: 14 additions & 0 deletions clang/test/CIR/CodeGen/complex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,3 +176,17 @@ void foo7() {
// OGCG: store float %[[TMP_A]], ptr %[[C_REAL_PTR]], align 4
// OGCG: store float 2.000000e+00, ptr %[[C_IMAG_PTR]], align 4

void foo8() {
Copy link
Contributor

@andykaylor andykaylor Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for integer types?

double _Complex c = 2.00i;
}

// CIR: %[[COMPLEX:.*]] = cir.const #cir.const_complex<#cir.fp<0.000000e+00> : !cir.double, #cir.fp<2.000000e+00> : !cir.double> : !cir.complex<!cir.double>

// LLVM: %[[COMPLEX:.*]] = alloca { double, double }, i64 1, align 8
// LLVM: store { double, double } { double 0.000000e+00, double 2.000000e+00 }, ptr %[[COMPLEX]], align 8

// OGCG: %[[COMPLEX:.*]] = alloca { double, double }, align 8
// OGCG: %[[C_REAL_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 0
// OGCG: %[[C_IMAG_PTR:.*]] = getelementptr inbounds nuw { double, double }, ptr %[[COMPLEX]], i32 0, i32 1
// OGCG: store double 0.000000e+00, ptr %[[C_REAL_PTR]], align 8
// OGCG: store double 2.000000e+00, ptr %[[C_IMAG_PTR]], align 8
Loading