[clang][bytecode] Avoid revisiting decomposition decl in visitDeclRef #144226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancern
added
the
clang:bytecode
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Sirui Mu (Lancern) ChangesThis simple patch removes the code to revisit Full diff: https://github.com/llvm/llvm-project/pull/144226.diff 2 Files Affected:
diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
index bf38b2e5d537d..9fe4803ce98ec 100644
--- a/clang/lib/AST/ByteCode/Compiler.cpp
+++ b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -6591,10 +6591,6 @@ bool Compiler<Emitter>::visitDeclRef(const ValueDecl *D, const Expr *E) {
return T->isReferenceType();
};
- // DecompositionDecls are just proxies for us.
- if (isa<DecompositionDecl>(VD))
- return revisit(VD);
-
if ((VD->hasGlobalStorage() || VD->isStaticDataMember()) &&
typeShouldBeVisited(VD->getType())) {
if (const Expr *Init = VD->getAnyInitializer();
diff --git a/clang/test/AST/ByteCode/structured-binding.cpp b/clang/test/AST/ByteCode/structured-binding.cpp
new file mode 100644
index 0000000000000..63eaad8448249
--- /dev/null
+++ b/clang/test/AST/ByteCode/structured-binding.cpp
@@ -0,0 +1,8 @@
+// RUN: %clang_cc1 -std=c++17 -verify %s -fexperimental-new-constant-interpreter
+// RUN: %clang_cc1 -std=c++17 -verify %s
+
+void f1() {
+ int arr[2] = {};
+ auto [a, b] = arr;
+ static_assert(&a != &b); // expected-no-diagnostics
+}
|
tbaederr
reviewed
Jun 15, 2025
Lancern
force-pushed
the
clang/bytecode/structured-binding
branch
from
50afed7 to
8046031
Compare
tbaederr
reviewed
Jun 15, 2025
Lancern
force-pushed
the
clang/bytecode/structured-binding
branch
from
8046031 to
72b99e6
Compare
tbaederr
reviewed
Jun 15, 2025
clang/test/AST/ByteCode/cxx17.cpp
Outdated
Contributor
There was a problem hiding this comment.
You forgot the namespace name
Member
Author
There was a problem hiding this comment.
Sorry about that... Updated.
Lancern
force-pushed
the
clang/bytecode/structured-binding
branch
from
72b99e6 to
c9649ce
Compare
Member
Author
|
I'll merge it once the CI is green. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/9465 Here is the relevant piece of the build log for the reference |
akuhlens
pushed a commit
to akuhlens/llvm-project
that referenced
this pull request
Jun 24, 2025
…llvm#144226) This simple patch removes the code to revisit `DecompositionDecl` in `visitDeclRef`. The revisit will try to emit the initializer of the `DecompositionDecl`, which could result in evaluation errors if the `DecompositionDecl` is not within a constexpr context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple patch removes the code to revisit
DecompositionDeclinvisitDeclRef. The revisit will try to emit the initializer of theDecompositionDecl, which could result in evaluation errors if theDecompositionDeclis not within a constexpr context.