Skip to content

Conversation

@kazutakahirata
Copy link
Contributor

Note that LLVM Coding Standards discourages for_each.

Note that LLVM Coding Standards discourages for_each.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Jun 15, 2025
@kazutakahirata kazutakahirata changed the title [clang] Use a range-based for loop (NFC) [Sema] Use a range-based for loop (NFC) Jun 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 15, 2025

@llvm/pr-subscribers-clang

Author: Kazu Hirata (kazutakahirata)

Changes

Note that LLVM Coding Standards discourages for_each.


Full diff: https://github.com/llvm/llvm-project/pull/144252.diff

1 Files Affected:

  • (modified) clang/lib/Sema/SemaOverload.cpp (+2-3)
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 49e5a311e239e..8c5f81f126c7a 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -9272,11 +9272,10 @@ class BuiltinOperatorOverloadBuilder {
     /// the candidates into a unique set, then move from that set into the list
     /// of arithmetic types.
     llvm::SmallSetVector<CanQualType, 2> BitIntCandidates;
-    llvm::for_each(CandidateTypes, [&BitIntCandidates](
-                                       BuiltinCandidateTypeSet &Candidate) {
+    for (BuiltinCandidateTypeSet &Candidate : CandidateTypes) {
       for (QualType BitTy : Candidate.bitint_types())
         BitIntCandidates.insert(CanQualType::CreateUnsafe(BitTy));
-    });
+    }
     llvm::move(BitIntCandidates, std::back_inserter(ArithmeticTypes));
     LastPromotedIntegralType = ArithmeticTypes.size();
     LastPromotedArithmeticType = ArithmeticTypes.size();

Copy link
Member

@el-ev el-ev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazutakahirata kazutakahirata merged commit 8f5c338 into llvm:main Jun 15, 2025
10 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_20250615_for_each_clang_Sema branch June 15, 2025 17:33
akuhlens pushed a commit to akuhlens/llvm-project that referenced this pull request Jun 24, 2025
Note that LLVM Coding Standards discourages for_each.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants