Skip to content

[DirectX] Implement memcpy in DXIL CBuffer Access pass #144436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2025
Merged

[DirectX] Implement memcpy in DXIL CBuffer Access pass #144436

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f1988f4
Expect only Load and GEP users of Globals, and report error otherwise
Icohedron Jun 2, 2025
c24411f
Refactor DXIL CBuffer Access pass
Icohedron Jun 13, 2025
b96adb5
Implement memcpy in DXIL CBuffer Access
Icohedron Jun 16, 2025
6ab934d
Add comment explaining CopyElemsImpl function
Icohedron Jun 16, 2025
14ce485
Add test for 0 byte copy and copy one element. Fix 0 byte copy implem…
Icohedron Jun 20, 2025
7a3dbe2
Move recursive lambda to a module-level function
Icohedron Jun 30, 2025
85148e3
Use an llvm_unreachable for unexpected user of global error
Icohedron Jun 30, 2025
2d7b780
Early return loadValue if loading only one element
Icohedron Jun 30, 2025
eefb7f4
Apply clang-format
Icohedron Jun 30, 2025
70fb42a
Remove redundant includes
Icohedron Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion llvm/lib/Target/DirectX/DXILCBufferAccess.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@
#include "llvm/Frontend/HLSL/CBuffer.h"
#include "llvm/Frontend/HLSL/HLSLResource.h"
#include "llvm/IR/IRBuilder.h"
#include "llvm/IR/IntrinsicInst.h"
#include "llvm/IR/IntrinsicsDirectX.h"
#include "llvm/IR/Operator.h"
#include "llvm/InitializePasses.h"
#include "llvm/Pass.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Transforms/Utils/Local.h"

#define DEBUG_TYPE "dxil-cbuffer-access"
Expand Down Expand Up @@ -161,7 +164,12 @@ static void replaceAccessesWithHandle(GlobalVariable *Global,
}

// Otherwise, walk users looking for a load...
ToProcess.append(Cur->user_begin(), Cur->user_end());
if (isa<GetElementPtrInst>(Cur) || isa<GEPOperator>(Cur)) {
ToProcess.append(Cur->user_begin(), Cur->user_end());
continue;
}

reportFatalInternalError("Unexpected user of Global");
}
RecursivelyDeleteTriviallyDeadInstructions(DeadInsts);
}
Expand Down