-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[AArch64] Add option -msve-streaming-vector-bits= . #144611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
c28804a
cb8936f
b772f08
6740565
9e3f500
283ad46
fb4a10d
34e0654
cf24a0b
b9144c7
d889fd7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -820,16 +820,23 @@ AArch64TargetInfo::getTargetBuiltins() const { | |||||
|
|
||||||
| std::optional<std::pair<unsigned, unsigned>> | ||||||
| AArch64TargetInfo::getVScaleRange(const LangOptions &LangOpts, | ||||||
| bool IsArmStreamingFunction, | ||||||
| ArmStreamingKind IsArmStreamingFunction, | ||||||
|
||||||
| ArmStreamingKind IsArmStreamingFunction, | |
| ArmStreamingKind Mode, |
(here and in other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just "Mode" on its own seems sort of confusing? Not sure what a better name is, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think calling the enum ArmStreamingMode and the parameter StreamingMode would be okay ("StreamingKind" is a little inconsistent as everywhere else this is referred to as the streaming mode).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My primary objection is that IsArmStreamingFunction suggests the type is a bool, but is instead an enum with more than 2 values.
Because the variable is of type ArmStreamingKind and is compared everywhere to enums named 'Streaming' 'StreamingCompatible' and 'NotStreaming', I think Mode is clear enough of a name. @MacDue's suggestion to use StreamingMode is also confusing because "streaming [SVE] mode" is another way of saying that PSTATE.SM=1.
Uh oh!
There was an error while loading. Please reload this page.