-
Notifications
You must be signed in to change notification settings - Fork 15.4k
ARM: Move declaration of supportSplitCSR to be public #144679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARM: Move declaration of supportSplitCSR to be public #144679
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
@llvm/pr-subscribers-backend-arm Author: Matt Arsenault (arsenm) ChangesThis is an implementation of a public method from the base Full diff: https://github.com/llvm/llvm-project/pull/144679.diff 1 Files Affected:
diff --git a/llvm/lib/Target/ARM/ARMISelLowering.h b/llvm/lib/Target/ARM/ARMISelLowering.h
index 87710ee29a249..e48967bd7f262 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.h
+++ b/llvm/lib/Target/ARM/ARMISelLowering.h
@@ -716,6 +716,11 @@ class VectorType;
return true;
}
+ bool supportSplitCSR(MachineFunction *MF) const override {
+ return MF->getFunction().getCallingConv() == CallingConv::CXX_FAST_TLS &&
+ MF->getFunction().hasFnAttribute(Attribute::NoUnwind);
+ }
+
bool hasStandaloneRem(EVT VT) const override {
return HasStandaloneRem;
}
@@ -914,11 +919,6 @@ class VectorType;
SmallVectorImpl<SDValue> &InVals, bool isThisReturn,
SDValue ThisVal, bool isCmseNSCall) const;
- bool supportSplitCSR(MachineFunction *MF) const override {
- return MF->getFunction().getCallingConv() == CallingConv::CXX_FAST_TLS &&
- MF->getFunction().hasFnAttribute(Attribute::NoUnwind);
- }
-
void initializeSplitCSR(MachineBasicBlock *Entry) const override;
void insertCopiesSplitCSR(
MachineBasicBlock *Entry,
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
290705f to
d967f60
Compare
efriedma-quic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is an implementation of a public method from the base class, so it should also be public. Avoids unrelated diff in a future patch.
d967f60 to
5a2e7ec
Compare

This is an implementation of a public method from the base
class, so it should also be public. Avoids unrelated diff
in a future patch.