Skip to content

Conversation

@arsenm
Copy link
Contributor

@arsenm arsenm commented Jun 18, 2025

This is an implementation of a public method from the base
class, so it should also be public. Avoids unrelated diff
in a future patch.

Copy link
Contributor Author

arsenm commented Jun 18, 2025

@llvmbot
Copy link
Member

llvmbot commented Jun 18, 2025

@llvm/pr-subscribers-backend-arm

Author: Matt Arsenault (arsenm)

Changes

This is an implementation of a public method from the base
class, so it should also be public. Avoids unrelated diff
in a future patch.


Full diff: https://github.com/llvm/llvm-project/pull/144679.diff

1 Files Affected:

  • (modified) llvm/lib/Target/ARM/ARMISelLowering.h (+5-5)
diff --git a/llvm/lib/Target/ARM/ARMISelLowering.h b/llvm/lib/Target/ARM/ARMISelLowering.h
index 87710ee29a249..e48967bd7f262 100644
--- a/llvm/lib/Target/ARM/ARMISelLowering.h
+++ b/llvm/lib/Target/ARM/ARMISelLowering.h
@@ -716,6 +716,11 @@ class VectorType;
       return true;
     }
 
+    bool supportSplitCSR(MachineFunction *MF) const override {
+      return MF->getFunction().getCallingConv() == CallingConv::CXX_FAST_TLS &&
+          MF->getFunction().hasFnAttribute(Attribute::NoUnwind);
+    }
+
     bool hasStandaloneRem(EVT VT) const override {
       return HasStandaloneRem;
     }
@@ -914,11 +919,6 @@ class VectorType;
                             SmallVectorImpl<SDValue> &InVals, bool isThisReturn,
                             SDValue ThisVal, bool isCmseNSCall) const;
 
-    bool supportSplitCSR(MachineFunction *MF) const override {
-      return MF->getFunction().getCallingConv() == CallingConv::CXX_FAST_TLS &&
-          MF->getFunction().hasFnAttribute(Attribute::NoUnwind);
-    }
-
     void initializeSplitCSR(MachineBasicBlock *Entry) const override;
     void insertCopiesSplitCSR(
       MachineBasicBlock *Entry,

@arsenm arsenm marked this pull request as ready for review June 18, 2025 12:07
@github-actions
Copy link

github-actions bot commented Jun 18, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@arsenm arsenm force-pushed the users/arsenm/arm/move-supportSplitCSR-declaration-to-public branch from 290705f to d967f60 Compare June 18, 2025 12:11
Copy link
Collaborator

@efriedma-quic efriedma-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor Author

arsenm commented Jun 19, 2025

Merge activity

  • Jun 19, 12:33 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 19, 12:34 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 19, 12:36 AM UTC: @arsenm merged this pull request with Graphite.

This is an implementation of a public method from the base
class, so it should also be public. Avoids unrelated diff
in a future patch.
@arsenm arsenm force-pushed the users/arsenm/arm/move-supportSplitCSR-declaration-to-public branch from d967f60 to 5a2e7ec Compare June 19, 2025 00:34
@arsenm arsenm merged commit bc8908a into main Jun 19, 2025
5 of 7 checks passed
@arsenm arsenm deleted the users/arsenm/arm/move-supportSplitCSR-declaration-to-public branch June 19, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants