[mlir] mlir/test/lit.local.cfg -> mlir/test/Target/SPIRV/lit.local.cfg #144685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-spirv @llvm/pr-subscribers-mlir Author: Frank Schlimbach (fschlimb) ChangesProbably an accident in #143108 (@davidegrohmann): The introduced lit.local.cfg basically muted all mlir lit tests. Full diff: https://github.com/llvm/llvm-project/pull/144685.diff 1 Files Affected:
diff --git a/mlir/test/lit.local.cfg b/mlir/test/Target/SPIRV/lit.local.cfg
similarity index 100%
rename from mlir/test/lit.local.cfg
rename to mlir/test/Target/SPIRV/lit.local.cfg
|
This was referenced Jun 18, 2025
kuhar
added a commit
that referenced
this pull request
Jun 18, 2025
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jun 18, 2025
… when serializing" and follow up commits (#144773) This reverts the following PRs: * llvm/llvm-project#143108 * llvm/llvm-project#144538 * llvm/llvm-project#144685 Reverting because this disabled tests when building without the llvm spirv backend enabled.
kuhar
pushed a commit
that referenced
this pull request
Jul 28, 2025
…lizing" (#145687) This relands PRs #143108 and #144538. The original PR was reverted due to a mistake that made all the mlir tests run only if SPIRV target was enabled. This is now resolved since enabling spirv-tools does not required SPIRV target any longer. spirv-tools are not required by default to run SPIRV mlir tests, but they can be optionally enabled in some SPIRV mlir test to verify that the produced SPIRV assembly pass validation. The other reverted PR #144685 is not longer needed and not part of this relanding. Original commit message: > At the MLIR level unsigned integer and signless integers are different types. Indeed when looking up the two types in type definition cache they do not match. > Hence when translating a SPIR-V module which contains both usign and signless integers will contain the same type declaration twice (something like OpTypeInt 32 0) which is not permitted in SPIR-V and such generated modules fail validation. > This patch solves the problem by mapping unisgned integer types to singless integer types before looking up in the type definition cache. --------- Signed-off-by: Davide Grohmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably an accident in #143108 (@davidegrohmann): The introduced lit.local.cfg basically muted all mlir lit tests.
renamed: mlir/test/lit.local.cfg -> mlir/test/Target/SPIRV/lit.local.cfg