[TargetParser][cmake] Be Smarter about TableGen Deps #144848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tries to be a bit smarter for the OLD behaviour of CMP0116, to glob more relevant directories looking for possible dependencies. The changes are: - Remove some duplication of lines in the `tablegen` function. - Put CURRENT_SOURCE_DIR into `tblgen_includes` (at the front) - Glob all directories in `tblgen_includes` - Give up on `local_tds` which was wrong when using tablegen to compile a file in a different directory (as TargetParser does) - Use `EXTRA_INCLUDES` in TargetParser `tablegen` calls. This is still an under-approximation of what might be included, at least comparing the RISCVTargetParserDef.inc.d (after building `target_parser_gen`), and the list of deps in the ninja file when explicitly setting CMP0116 to OLD. Fixes llvm#144639
tclin914
reviewed
Jun 19, 2025
tclin914
approved these changes
Jun 20, 2025
Contributor
tclin914
left a comment
tclin914
left a comment
There was a problem hiding this comment.
I've reviewed every line of this change — it looks good to me. I also tested it locally, and it works well. I hope I didn't miss anything.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Jun 22, 2025
…des series cpus." (#144402)" Since the fix llvm/llvm-project#144848 for post-commit CI failure has landed. This reverts commit f83d09a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to be a bit smarter for the OLD behaviour of CMP0116, to glob more relevant directories looking for possible dependencies.
The changes are:
tablegenfunction.tblgen_includes(at the front)tblgen_includeslocal_tdswhich was wrong when using tablegen to compile a file in a different directory (as TargetParser does)EXTRA_INCLUDESin TargetParsertablegencalls.This is still an under-approximation of what might be included, at least comparing the RISCVTargetParserDef.inc.d (after building
target_parser_gen), and the list of deps in the ninja file when explicitly setting CMP0116 to OLD.Fixes #144639