[FuzzMutate] Prevent the mutator from generating illegal memory operations #144885
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
mgcarrasco
force-pushed
the
pr/ir-mutator-addrspace
branch
from
3b1298e to
67ca2bf
Compare
|
Can you attach an AMDGCN specific test case? IIUC the |
|
@DataCorrupted thanks for the review. I'll provide the unit test. |
mgcarrasco
force-pushed
the
pr/ir-mutator-addrspace
branch
3 times, most recently
from
e9b0f59 to
39f8169
Compare
|
@DataCorrupted thanks again for the feedback. I've added a unit test. We are also planning to incorporate this check into the Verifier in an independent PR. Once that is done, I can also remove the adhoc check for addrspace 8 in a new PR. |
mgcarrasco
force-pushed
the
pr/ir-mutator-addrspace
branch
from
39f8169 to
ccee029
Compare
|
The last failure looks unrelated to this PR. I have just rebased to try again. |
mgcarrasco
force-pushed
the
pr/ir-mutator-addrspace
branch
from
ccee029 to
c5b2a5b
Compare
DataCorrupted
left a comment
DataCorrupted
left a comment
There was a problem hiding this comment.
Thanks for the test, only some small changes required.
mgcarrasco
force-pushed
the
pr/ir-mutator-addrspace
branch
from
41550a7 to
0daba8d
Compare
|
Thanks @DataCorrupted, I missed those cases. |
|
@DataCorrupted thanks again for your review and feedback. I've addressed the remaining comments. In case the latest changes look good to you, I think the PR could be merged. |
2 participants
This PR prevents the mutator from generating illegal memory operations for AMDGCN. In particular, direct store and load instructions on addrspace(8) are not permitted. This PR fixes that by properly introducing casts to addrspace(7) when required.