Skip to content

Conversation

@saturn691
Copy link
Contributor

A typo, set() instead of list() would cause the build to not define LIBC_CONF_ERRNO_MODE, which would cause the wrong configuration to be used.

A typo, set() instead of list() would cause the build to not define
LIBC_CONF_ERRNO_MODE, which would cause the wrong configuration to
be used.
@llvmbot llvmbot added the libc label Jun 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 19, 2025

@llvm/pr-subscribers-libc

Author: William Huynh (saturn691)

Changes

A typo, set() instead of list() would cause the build to not define LIBC_CONF_ERRNO_MODE, which would cause the wrong configuration to be used.


Full diff: https://github.com/llvm/llvm-project/pull/144896.diff

1 Files Affected:

  • (modified) libc/cmake/modules/LLVMLibCCompileOptionRules.cmake (+1-1)
diff --git a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
index a98e7276bef80..82d06e2b9eb55 100644
--- a/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
+++ b/libc/cmake/modules/LLVMLibCCompileOptionRules.cmake
@@ -107,7 +107,7 @@ function(_get_compile_options_from_config output_var)
   endif()
 
   if(LIBC_CONF_ERRNO_MODE)
-    set(APPEND config_options "-DLIBC_ERRNO_MODE=${LIBC_CONF_ERRNO_MODE}")
+    list(APPEND config_options "-DLIBC_ERRNO_MODE=${LIBC_CONF_ERRNO_MODE}")
   endif()
 
   set(${output_var} ${config_options} PARENT_SCOPE)

@lntue lntue merged commit baf35d7 into llvm:main Jun 19, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants