AMDGPU: Avoid report_fatal_error for reporting libcalls

[arsenm]

No description provided.

[arsenm]

• AMDGPU: Avoid report_fatal_error for reporting libcalls #145134 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-backend-amdgpu

Author: Matt Arsenault (arsenm)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/145134.diff

1 Files Affected:

• (modified) llvm/lib/Target/AMDGPU/SIISelLowering.cpp (+1-1)

diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 07d79d677104a..b752ccd6e14b1 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -3805,7 +3805,7 @@ SDValue SITargetLowering::LowerCall(CallLoweringInfo &CLI,
   }
 
   if (!CLI.CB)
-    report_fatal_error("unsupported libcall legalization");
+    return lowerUnhandledCall(CLI, InVals, "unsupported libcall legalization");
 
   if (IsTailCall && MF.getTarget().Options.GuaranteedTailCallOpt) {
     return lowerUnhandledCall(CLI, InVals,

[rampitec]

Then how the error will look now for an user?

[arsenm]

Then how the error will look now for an user?

Should be
error: : ....

[shiltian]

but there is no test for that?

[rampitec]

but there is no test for that?

Ideally we should have one... But there was not one before too.

[arsenm]

but there is no test for that?

Ideally we should have one... But there was not one before too.

This isn't really supposed to happen in the first place so there isn't a reliable test. Would need to have a known broken operation

[shiltian]

but if that should really not happen, existing report_fatal_error might be good?

[arsenm]

but if that should really not happen, existing report_fatal_error might be good?

report_fatal_error is never good. Also it's highly likely to appear with the legalizer's bias towards libcalls by default