Skip to content

[clang][nvlink-wrapper] Add support for opt-remarks command line options #145365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhuber6 merged 5 commits into from
Jun 23, 2025
Merged

[clang][nvlink-wrapper] Add support for opt-remarks command line options #145365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7232749
[clang][nvlink-wrapper] Add support for opt-remarks command line options
miguelcsx Jun 22, 2025
a649e2a
[clang][nvlink-wrapper] Modified tablegen option definitions
miguelcsx Jun 22, 2025
f61d7a8
[clang][nvlink-wrapper] Modified tablegen option definitions
miguelcsx Jun 22, 2025
9e896a5
Format ClangNVLinkWrapper.cpp to pass code formatting checks
miguelcsx Jun 23, 2025
cd05c21
Merge branch 'llvm:main' into nvlink-remarks/feat
miguelcsx Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions clang/tools/clang-nvlink-wrapper/ClangNVLinkWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,16 @@ Expected<std::unique_ptr<lto::LTO>> createLTO(const ArgList &Args) {
Conf.CPU = Args.getLastArgValue(OPT_arch);
Conf.Options = codegen::InitTargetOptionsFromCodeGenFlags(Triple);

Conf.RemarksFilename = RemarksFilename;
Conf.RemarksPasses = RemarksPasses;
Conf.RemarksWithHotness = RemarksWithHotness;
Conf.RemarksFilename =
Args.getLastArgValue(OPT_opt_remarks_filename, RemarksFilename);
Conf.RemarksPasses =
Args.getLastArgValue(OPT_opt_remarks_filter, RemarksPasses);
Conf.RemarksFormat =
Args.getLastArgValue(OPT_opt_remarks_format, RemarksFormat);

Conf.RemarksWithHotness =
Args.hasArg(OPT_opt_remarks_with_hotness) || RemarksWithHotness;
Conf.RemarksHotnessThreshold = RemarksHotnessThreshold;
Conf.RemarksFormat = RemarksFormat;

Conf.MAttrs = llvm::codegen::getMAttrs();
std::optional<CodeGenOptLevel> CGOptLevelOrNone =
Expand Down
10 changes: 10 additions & 0 deletions clang/tools/clang-nvlink-wrapper/NVLinkOpts.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,16 @@ def : Joined<["--", "-"], "plugin-opt=emit-llvm">,
Flags<[WrapperOnlyOption]>, Alias<lto_emit_llvm>;
def : Joined<["--", "-"], "plugin-opt=emit-asm">,
Flags<[WrapperOnlyOption]>, Alias<lto_emit_asm>;

def opt_remarks_filename : Joined<["--", "-"], "plugin-opt=opt-remarks-filename=">,
Flags<[WrapperOnlyOption]>, HelpText<"YAML output file for optimization remarks">;
def opt_remarks_format : Joined<["--", "-"], "plugin-opt=opt-remarks-format=">,
Flags<[WrapperOnlyOption]>, HelpText<"The format used for serializing remarks (default: YAML)">;
def opt_remarks_filter : Joined<["--", "-"], "plugin-opt=opt-remarks-filter=">,
Flags<[WrapperOnlyOption]>, HelpText<"Regex for the passes that need to be serialized to the output file">;
def opt_remarks_with_hotness : Flag<["--", "-"], "plugin-opt=opt-remarks-with-hotness">,
Flags<[WrapperOnlyOption]>, HelpText<"Include hotness information in the optimization remarks file">;

def plugin_opt : Joined<["--", "-"], "plugin-opt=">, Flags<[WrapperOnlyOption]>,
HelpText<"Options passed to LLVM, not including the Clang invocation. Use "
"'--plugin-opt=--help' for a list of options.">;
Expand Down
Loading