Skip to content

[DFAJumpThreading] Prevent pass from using too much memory. #145482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions llvm/lib/Transforms/Scalar/DFAJumpThreading.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -582,15 +582,17 @@ struct AllSwitchPaths {
VisitedBlocks VB;
// Get paths from the determinator BBs to SwitchPhiDefBB
std::vector<ThreadingPath> PathsToPhiDef =
getPathsFromStateDefMap(StateDef, SwitchPhi, VB);
getPathsFromStateDefMap(StateDef, SwitchPhi, VB, MaxNumPaths);
if (SwitchPhiDefBB == SwitchBlock) {
TPaths = std::move(PathsToPhiDef);
return;
}

assert(MaxNumPaths >= PathsToPhiDef.size());
auto PathsLimit = MaxNumPaths / PathsToPhiDef.size();
// Find and append paths from SwitchPhiDefBB to SwitchBlock.
PathsType PathsToSwitchBB =
paths(SwitchPhiDefBB, SwitchBlock, VB, /* PathDepth = */ 1);
paths(SwitchPhiDefBB, SwitchBlock, VB, /* PathDepth = */ 1, PathsLimit);
if (PathsToSwitchBB.empty())
return;

Expand All @@ -611,13 +613,16 @@ struct AllSwitchPaths {
typedef DenseMap<const BasicBlock *, const PHINode *> StateDefMap;
std::vector<ThreadingPath> getPathsFromStateDefMap(StateDefMap &StateDef,
PHINode *Phi,
VisitedBlocks &VB) {
VisitedBlocks &VB,
unsigned PathsLimit) {
std::vector<ThreadingPath> Res;
auto *PhiBB = Phi->getParent();
VB.insert(PhiBB);

VisitedBlocks UniqueBlocks;
for (auto *IncomingBB : Phi->blocks()) {
if (Res.size() >= PathsLimit)
break;
if (!UniqueBlocks.insert(IncomingBB).second)
continue;
if (!SwitchOuterLoop->contains(IncomingBB))
Expand Down Expand Up @@ -653,8 +658,9 @@ struct AllSwitchPaths {

// Direct predecessor, just add to the path.
if (IncomingPhiDefBB == IncomingBB) {
std::vector<ThreadingPath> PredPaths =
getPathsFromStateDefMap(StateDef, IncomingPhi, VB);
assert(PathsLimit > Res.size());
std::vector<ThreadingPath> PredPaths = getPathsFromStateDefMap(
StateDef, IncomingPhi, VB, PathsLimit - Res.size());
for (ThreadingPath &Path : PredPaths) {
Path.push_back(PhiBB);
Res.push_back(std::move(Path));
Expand All @@ -667,13 +673,17 @@ struct AllSwitchPaths {
continue;

PathsType IntermediatePaths;
IntermediatePaths =
paths(IncomingPhiDefBB, IncomingBB, VB, /* PathDepth = */ 1);
assert(PathsLimit > Res.size());
auto InterPathLimit = PathsLimit - Res.size();
IntermediatePaths = paths(IncomingPhiDefBB, IncomingBB, VB,
/* PathDepth = */ 1, InterPathLimit);
if (IntermediatePaths.empty())
continue;

assert(InterPathLimit >= IntermediatePaths.size());
auto PredPathLimit = InterPathLimit / IntermediatePaths.size();
std::vector<ThreadingPath> PredPaths =
getPathsFromStateDefMap(StateDef, IncomingPhi, VB);
getPathsFromStateDefMap(StateDef, IncomingPhi, VB, PredPathLimit);
for (const ThreadingPath &Path : PredPaths) {
for (const PathType &IPath : IntermediatePaths) {
ThreadingPath NewPath(Path);
Expand All @@ -688,7 +698,7 @@ struct AllSwitchPaths {
}

PathsType paths(BasicBlock *BB, BasicBlock *ToBB, VisitedBlocks &Visited,
unsigned PathDepth) {
unsigned PathDepth, unsigned PathsLimit) {
PathsType Res;

// Stop exploring paths after visiting MaxPathLength blocks
Expand All @@ -715,6 +725,8 @@ struct AllSwitchPaths {
// is used to prevent a duplicate path from being generated
SmallSet<BasicBlock *, 4> Successors;
for (BasicBlock *Succ : successors(BB)) {
if (Res.size() >= PathsLimit)
break;
if (!Successors.insert(Succ).second)
continue;

Expand All @@ -736,14 +748,12 @@ struct AllSwitchPaths {
// coverage and compile time.
if (LI->getLoopFor(Succ) != CurrLoop)
continue;

PathsType SuccPaths = paths(Succ, ToBB, Visited, PathDepth + 1);
assert(PathsLimit > Res.size());
PathsType SuccPaths =
paths(Succ, ToBB, Visited, PathDepth + 1, PathsLimit - Res.size());
for (PathType &Path : SuccPaths) {
Path.push_front(BB);
Res.push_back(Path);
if (Res.size() >= MaxNumPaths) {
return Res;
}
}
}
// This block could now be visited again from a different predecessor. Note
Expand Down
Loading