Skip to content

AlwaysInliner: Factor out some code in preparation for a future change. #145614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

AlwaysInliner: Factor out some code in preparation for a future change. #145614

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fd7e07
[𝘀𝗽𝗿] initial version
aemerson Jun 24, 2025
209fe80
clang-format
aemerson Jun 25, 2025
b47e93e
Address comments.
aemerson Jun 26, 2025
81d4550
Rebase
aemerson Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 41 additions & 26 deletions llvm/lib/Transforms/IPO/AlwaysInliner.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,44 @@ using namespace llvm;

namespace {

bool canInlineCallBase(CallBase *CB) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool canInlineCallBase(CallBase *CB) {
static bool canInlineCallBase(CallBase *CB) {

Could you also add a brief doc-comment?

return CB->hasFnAttr(Attribute::AlwaysInline) &&
!CB->getAttributes().hasFnAttr(Attribute::NoInline);
}

bool attemptInlineFunction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool attemptInlineFunction(
static bool attemptInlineFunction(

Could you also add a brief doc-comment?

Function &F, CallBase *CB, bool InsertLifetime,
function_ref<AAResults &(Function &)> &GetAAR,
function_ref<AssumptionCache &(Function &)> &GetAssumptionCache,
ProfileSummaryInfo &PSI) {
Function *Caller = CB->getCaller();
OptimizationRemarkEmitter ORE(Caller);
DebugLoc DLoc = CB->getDebugLoc();
BasicBlock *Block = CB->getParent();

InlineFunctionInfo IFI(GetAssumptionCache, &PSI, nullptr, nullptr);
InlineResult Res = InlineFunction(*CB, IFI, /*MergeAttributes=*/true,
&GetAAR(F), InsertLifetime);
if (!Res.isSuccess()) {
ORE.emit([&]() {
return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined", DLoc, Block)
<< "'" << ore::NV("Callee", &F) << "' is not inlined into '"
<< ore::NV("Caller", Caller)
<< "': " << ore::NV("Reason", Res.getFailureReason());
});
return false;
}

emitInlinedIntoBasedOnCost(ORE, DLoc, Block, F, *Caller,
InlineCost::getAlways("always inline attribute"),
/*ForProfileContext=*/false, DEBUG_TYPE);

return true;
}

/// This function inlines all functions that are marked with the always_inline
/// attribute. It also removes the inlined functions if they are dead after the
/// inlining process.
bool AlwaysInlineImpl(
Module &M, bool InsertLifetime, ProfileSummaryInfo &PSI,
FunctionAnalysisManager *FAM,
Expand All @@ -50,36 +88,13 @@ bool AlwaysInlineImpl(

for (User *U : F.users())
if (auto *CB = dyn_cast<CallBase>(U))
if (CB->getCalledFunction() == &F &&
CB->hasFnAttr(Attribute::AlwaysInline) &&
!CB->getAttributes().hasFnAttr(Attribute::NoInline))
if (CB->getCalledFunction() == &F && canInlineCallBase(CB))
Calls.insert(CB);

for (CallBase *CB : Calls) {
Function *Caller = CB->getCaller();
OptimizationRemarkEmitter ORE(Caller);
DebugLoc DLoc = CB->getDebugLoc();
BasicBlock *Block = CB->getParent();

InlineFunctionInfo IFI(GetAssumptionCache, &PSI, nullptr, nullptr);
InlineResult Res = InlineFunction(*CB, IFI, /*MergeAttributes=*/true,
&GetAAR(F), InsertLifetime);
if (!Res.isSuccess()) {
ORE.emit([&]() {
return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined", DLoc, Block)
<< "'" << ore::NV("Callee", &F) << "' is not inlined into '"
<< ore::NV("Caller", Caller)
<< "': " << ore::NV("Reason", Res.getFailureReason());
});
continue;
}

emitInlinedIntoBasedOnCost(
ORE, DLoc, Block, F, *Caller,
InlineCost::getAlways("always inline attribute"),
/*ForProfileContext=*/false, DEBUG_TYPE);

Changed = true;
Changed |= attemptInlineFunction(F, CB, InsertLifetime, GetAAR,
GetAssumptionCache, PSI);
if (FAM)
FAM->invalidate(*Caller, PreservedAnalyses::none());
}
Expand Down
Loading