Skip to content

[lldb] Adding pipe support to lldb_private::MainLoopWindows. #145621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2025
Merged

[lldb] Adding pipe support to lldb_private::MainLoopWindows. #145621

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79c10b6
[lldb] Adding file and pipe support to lldb_private::MainLoopWindows.
ashgti Jun 26, 2025
a935e75
Adopting a different strategy for monitoring pipes and files.
ashgti Jun 27, 2025
0f07158
Removing disk file support and reverting unrelated changes.
ashgti Jun 27, 2025
65430e3
Apply clang-format.
ashgti Jun 27, 2025
ea1ed2b
Apply clang-format again.
ashgti Jun 27, 2025
024a7d9
Apply suggestions from code review
ashgti Jun 30, 2025
3018481
Update lldb/source/Host/windows/MainLoopWindows.cpp
ashgti Jun 30, 2025
d74d132
Fixing an assert.
ashgti Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lldb/unittests/Host/MainLoopTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ TEST_F(MainLoopTest, NoSpuriousPipeReads) {
// pipe is empty, and we should not be called anymore.
char X;
size_t len = sizeof(X);
EXPECT_THAT_EXPECTED(r->Read(&X, len).ToError(), llvm::HasValue(1));
ASSERT_THAT_ERROR(r->Read(&X, len).ToError(), llvm::Succeeded());
EXPECT_EQ(len, sizeof(X));
EXPECT_EQ(X, 'X');
Comment on lines +127 to +129
Copy link
Collaborator

@labath labath Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I was looking at the interface for the pipe class. We really ought to rectify the two :/

}
++callback_count;
},
Expand Down Expand Up @@ -159,6 +161,7 @@ TEST_F(MainLoopTest, NoSpuriousSocketReads) {
EXPECT_THAT_ERROR(socketpair[1]->Read(&X, len).ToError(),
llvm::Succeeded());
EXPECT_EQ(len, sizeof(X));
EXPECT_EQ(X, 'X');
}
++callback_count;
},
Expand Down
Loading