Skip to content

[AMDGPU][SIInsertWaitcnts] don't crash when printing messages at end of block #145694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ssahasra merged 1 commit into from
Jun 25, 2025
Merged

[AMDGPU][SIInsertWaitcnts] don't crash when printing messages at end of block #145694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,7 +1353,13 @@ bool WaitcntGeneratorPreGFX12::applyPreexistingWaitcnt(
MachineInstr *WaitcntInstr = nullptr;
MachineInstr *WaitcntVsCntInstr = nullptr;

LLVM_DEBUG(dbgs() << "PreGFX12::applyPreexistingWaitcnt at: " << *It);
LLVM_DEBUG({
dbgs() << "PreGFX12::applyPreexistingWaitcnt at: ";
if (It == OldWaitcntInstr.getParent()->instr_end())
dbgs() << "end of block\n";
else
dbgs() << *It;
});

for (auto &II :
make_early_inc_range(make_range(OldWaitcntInstr.getIterator(), It))) {
Expand Down Expand Up @@ -1507,7 +1513,13 @@ bool WaitcntGeneratorGFX12Plus::applyPreexistingWaitcnt(
MachineInstr *CombinedStoreDsCntInstr = nullptr;
MachineInstr *WaitInstrs[NUM_EXTENDED_INST_CNTS] = {};

LLVM_DEBUG(dbgs() << "GFX12Plus::applyPreexistingWaitcnt at: " << *It);
LLVM_DEBUG({
dbgs() << "GFX12Plus::applyPreexistingWaitcnt at: ";
if (It == OldWaitcntInstr.getParent()->instr_end())
dbgs() << "end of block\n";
else
dbgs() << *It;
});

for (auto &II :
make_early_inc_range(make_range(OldWaitcntInstr.getIterator(), It))) {
Expand Down