Skip to content

[Offload] Add a stub unloadBinaryImpl for host device #145716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RossBrunton merged 1 commit into from
Jun 25, 2025
Merged

[Offload] Add a stub unloadBinaryImpl for host device #145716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions offload/plugins-nextgen/host/src/rtl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ struct GenELF64DeviceTy : public GenericDeviceTy {
/// Initialize the device, which is a no-op
Error initImpl(GenericPluginTy &Plugin) override { return Plugin::success(); }

/// Unload the binary image
///
/// TODO: This currently does nothing, and should be implemented as part of
/// broader memory handling logic for this plugin
Error unloadBinaryImpl(DeviceImageTy *) override { return Plugin::success(); }
Copy link
Contributor

@jhuber6 jhuber6 Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You likely want DynamicLibrary::closeLibrary().

Copy link
Contributor Author

@RossBrunton RossBrunton Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall I do that as a separate change, and just merge this as is to unbreak the buildbot?

Copy link
Contributor

@jhuber6 jhuber6 Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, though honestly there's probably a lot that needs to be fixed about this plugin.


/// Deinitialize the device, which is a no-op
Error deinitImpl() override { return Plugin::success(); }

Expand Down
Loading