Skip to content

[NFC] Make unwind table internal data structures more accessible #145804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025
Merged

[NFC] Make unwind table internal data structures more accessible #145804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3646d6e
Make unwind info internals more accessible
Jun 25, 2025
e35e4a0
Merge branch 'main' into make-unwind-table-internals-accessible
Jun 26, 2025
7610020
Merge branch 'main' into make-unwind-table-internals-accessible
Jun 26, 2025
5ef69e3
Merge branch 'main' into make-unwind-table-internals-accessible
Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ class UnwindLocation {
return *AddrSpace;
}
int32_t getConstant() const { return Offset; }
bool getDereference() const { return Dereference; }

/// Some opcodes will modify the CFA location's register only, so we need
/// to be able to modify the CFA register when evaluating DWARF Call Frame
/// Information opcodes.
Expand Down
12 changes: 6 additions & 6 deletions llvm/include/llvm/DebugInfo/DWARF/LowLevel/DWARFCFIProgram.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,6 @@ class CFIProgram {
/// above. This is indexed by opcode.
LLVM_ABI static ArrayRef<OperandType[MaxOperands]> getOperandTypes();

private:
std::vector<Instruction> Instructions;
const uint64_t CodeAlignmentFactor;
const int64_t DataAlignmentFactor;
Triple::ArchType Arch;

/// Convenience method to add a new instruction with the given opcode.
void addInstruction(uint8_t Opcode) {
Instructions.push_back(Instruction(Opcode));
Expand All @@ -286,6 +280,12 @@ class CFIProgram {
Instructions.back().Ops.push_back(Operand2);
Instructions.back().Ops.push_back(Operand3);
}

private:
std::vector<Instruction> Instructions;
const uint64_t CodeAlignmentFactor;
const int64_t DataAlignmentFactor;
Triple::ArchType Arch;
};

} // end namespace dwarf
Expand Down