Skip to content

Add modified runtimes back to runtimes_to_{test|build} #145805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025
Merged

Add modified runtimes back to runtimes_to_{test|build} #145805

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1439736
Add modified runtimes back to runtimes_to_build
amykhuang Jun 25, 2025
c58a3e2
Fix to make libc build as a runtime but not do this for other runtimes
amykhuang Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci/compute_projects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ def _compute_runtimes_to_build(
for modified_project in modified_projects:
if modified_project in DEPENDENT_RUNTIMES_TO_BUILD:
runtimes_to_build.update(DEPENDENT_RUNTIMES_TO_BUILD[modified_project])
if modified_project in RUNTIMES:
runtimes_to_build.add(modified_project)
return _exclude_projects(runtimes_to_build, platform)


Expand Down
6 changes: 3 additions & 3 deletions .ci/compute_projects_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,14 +187,14 @@ def test_top_level_file(self):
self.assertEqual(env_variables["runtimes_check_targets"], "")
self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "")

def test_exclude_runtiems_in_projects(self):
def test_exclude_runtimes_in_projects(self):
env_variables = compute_projects.get_env_variables(
["libcxx/CMakeLists.txt"], "Linux"
)
self.assertEqual(env_variables["projects_to_build"], "")
self.assertEqual(env_variables["project_check_targets"], "")
self.assertEqual(env_variables["runtimes_to_build"], "")
self.assertEqual(env_variables["runtimes_check_targets"], "")
self.assertEqual(env_variables["runtimes_to_build"], "libcxx")
self.assertEqual(env_variables["runtimes_check_targets"], "check-cxx")
self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "")

def test_exclude_docs(self):
Expand Down
Loading