Skip to content

[GlobalISel] Remove dead code. (NFC) #145811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025
Merged

[GlobalISel] Remove dead code. (NFC) #145811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10099,10 +10099,6 @@ LegalizerHelper::lowerMemCpyFamily(MachineInstr &MI, unsigned MaxLen) {
}

bool IsVolatile = MemOp->isVolatile();
if (Opc == TargetOpcode::G_MEMCPY_INLINE)
return lowerMemcpyInline(MI, Dst, Src, KnownLen, DstAlign, SrcAlign,
IsVolatile);

Comment on lines -10102 to -10105
Copy link
Contributor Author

@petechou petechou Jun 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help review the pr and merge it if it looks good. Thanks.

The assertion around L10073 should already test no G_MEMCPY_INLINE is expected. Actually, the code looks dead when it's first introduced in a642872, and is still kept in a later refactoring change 36527cb.

Copy link
Contributor

@arsenm arsenm Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lowerMemcpyInline overload is also probably dead

Copy link
Contributor Author

@petechou petechou Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I guess it's not. It's used in LegalizerHelper::lowerMemcpyInline(MachineInstr &MI) which is called by CombinerHelper::tryEmitMemcpyInline(MachineInstr &MI) from target pre-legalizer combiner.

// Don't try to optimize volatile.
if (IsVolatile)
return UnableToLegalize;
Expand Down