Skip to content

[NFC][lldb-dap] Add missing header guard for DAPError and ProgressEvent. #145915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
da-viper merged 2 commits into from
Jun 26, 2025
Merged

[NFC][lldb-dap] Add missing header guard for DAPError and ProgressEvent. #145915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbfc26b
[NFC][lldb-dap] add missing header guard.
da-viper Jun 26, 2025
a6d0752
[lldb-dap] add missing new line
da-viper Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lldb/tools/lldb-dap/DAPError.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
//
//===----------------------------------------------------------------------===//

#ifndef LLDB_TOOLS_LLDB_DAP_DAPERROR_H
#define LLDB_TOOLS_LLDB_DAP_DAPERROR_H

#include "llvm/Support/Error.h"
#include <optional>
#include <string>
Expand Down Expand Up @@ -50,3 +53,5 @@ class NotStoppedError : public llvm::ErrorInfo<NotStoppedError> {
};

} // namespace lldb_dap

#endif // LLDB_TOOLS_LLDB_DAP_DAPERROR_H
13 changes: 10 additions & 3 deletions lldb/tools/lldb-dap/ProgressEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,16 @@
//
//===----------------------------------------------------------------------===//

#ifndef LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
#define LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H

#include <atomic>
#include <chrono>
#include <mutex>
#include <optional>
#include <queue>
#include <thread>

#include "DAPForward.h"

#include "llvm/Support/JSON.h"

namespace lldb_dap {
Expand Down Expand Up @@ -129,8 +130,12 @@ class ProgressEventReporter {
public:
/// \param[in] report_callback
/// Function to invoke to report the event to the IDE.
ProgressEventReporter(ProgressEventReportCallback report_callback);
explicit ProgressEventReporter(ProgressEventReportCallback report_callback);

ProgressEventReporter(const ProgressEventReporter &) = delete;
ProgressEventReporter(ProgressEventReporter &&) = delete;
ProgressEventReporter &operator=(const ProgressEventReporter &) = delete;
ProgressEventReporter &operator=(ProgressEventReporter &&) = delete;
~ProgressEventReporter();

/// Add a new event to the internal queue and report the event if
Expand All @@ -156,3 +161,5 @@ class ProgressEventReporter {
};

} // namespace lldb_dap

#endif // LLDB_TOOLS_LLDB_DAP_PROGRESS_EVENT_H
Copy link
Member

@JDevlieghere JDevlieghere Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

Loading